Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated field privateCert from README, tests #591

Merged
merged 4 commits into from May 14, 2021

Conversation

sdaikichi
Copy link
Contributor

privateCert looks like it has been removed.
I hope this PR is accepted.

@cjbarth
Copy link
Collaborator

cjbarth commented May 13, 2021

Good catch @sdaikichi. However, further searching indicates that there are several more places where this is wrong. Would you be willing to update your PR with the occurrences in both README.md files and tests.spec.ts?

@cjbarth cjbarth added documentation Request for or contribution to documentation pending-refinement labels May 13, 2021
@cjbarth cjbarth changed the title remove deprecated field privateCert from README Remove deprecated field privateCert from README, tests May 14, 2021
@cjbarth cjbarth added this to the 3.0.0 milestone May 14, 2021
@cjbarth
Copy link
Collaborator

cjbarth commented May 14, 2021

@sdaikichi You'll probably need to merge the HEAD of master in to your branch to get it to pass tests.

@cjbarth cjbarth merged commit 4eff276 into node-saml:master May 14, 2021
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants