Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild changelog for 3.0.0 #605

merged 1 commit into from Jun 16, 2021

Rebuild changelog for 3.0.0 #605

merged 1 commit into from Jun 16, 2021


Copy link

@cjbarth cjbarth commented May 31, 2021

This is a rebuilt changelog for 3.0.0. This was built using a bunch of bug fixes in a private branch of github-release-notes. These fixes have been requested in a set of chained PRs started with this one.

Copy link

@christian-hawk christian-hawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a developer I still feel unsafe to update because of "node-saml separation" breaking change. Is it a real breaking change? Can more info be provided? Besides that it looks ok.

Copy link

markstos commented Jun 4, 2021

@christian-hawk Some internal pieces were moved to a separate module. Public, documented APIs were maintained.

As with other software upgrades, you should confirm that the passport-saml upgrade still passes the test suite for your own app.

If you use undocumented, internal methods, you should confirm that code still works.

Copy link

@markstos and all collabs, thx for reply. As is all documented, we are all good.
Anybody gonna merge this?

@cjbarth cjbarth added the documentation Request for or contribution to documentation label Jun 16, 2021
@cjbarth cjbarth merged commit c7b7226 into master Jun 16, 2021
5 checks passed
@cjbarth cjbarth deleted the changelog branch June 16, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
documentation Request for or contribution to documentation
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants