Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move history note to the bottom and expand it. #708

Merged
merged 2 commits into from Jun 27, 2022

Conversation

markstos
Copy link
Contributor

Before, one of the first sentences in the documentation was a history note about a fork that was made 10 years ago. That's not one of the first things people need to know about the project.

Now, a note on the history of the project has been moved to the bottom and expanded to credit the primary maintainers throughout the last decade.

During this commit, the project is about to turn 10 years old in 2 days!

The project was born on June 28th, 2012 with a commit by @bergie.

@markstos
Copy link
Contributor Author

@cjbarth Can 4.0 be released on June 28th? That's passport-saml's 10 year birthday!

@cjbarth
Copy link
Collaborator

cjbarth commented Jun 26, 2022

I will be unavailable to work on this project for the next few days, so I can't do a release on the anniversary. I know we're close, but there are lots of i's to dot and t's to cross before a release. Now that we actually have the beta versions out an on NPM, I think it will make it easier to get final feedback too. A lot has changed, and I don't want to mess people up with a security module that doesn't quite work.

@markstos
Copy link
Contributor Author

Sounds good, thanks!

@cjbarth cjbarth added the documentation Request for or contribution to documentation label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #708 (8d48320) into master (ba40d98) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   65.10%   65.10%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           97       97           
  Misses         29       29           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba40d98...8d48320. Read the comment docs.

@cjbarth cjbarth merged commit 3bfb230 into master Jun 27, 2022
8 checks passed
@cjbarth cjbarth deleted the add-history-to-readme branch June 27, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants