Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges for scoped package #709

Merged
merged 1 commit into from Jun 27, 2022
Merged

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Jun 27, 2022

Description

Update badges to correspond to the new NPM package location.

@cjbarth cjbarth added the documentation Request for or contribution to documentation label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #709 (657499d) into master (3bfb230) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   65.10%   65.10%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           97       97           
  Misses         29       29           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfb230...657499d. Read the comment docs.

@cjbarth cjbarth merged commit 4065e77 into node-saml:master Jun 27, 2022
8 checks passed
@cjbarth cjbarth deleted the update-badges branch June 27, 2022 13:35
@@ -1,8 +1,12 @@
# Passport-SAML

[![Build Status](https://github.com/node-saml/passport-saml/workflows/Build%20Status/badge.svg)](https://github.com/node-saml/passport-saml/actions?query=workflow%3ABuild%Status) [![GitHub version](https://badge.fury.io/gh/node-saml%2Fpassport-saml.svg)](https://badge.fury.io/gh/node-saml%2Fpassport-saml) [![npm version](https://badge.fury.io/js/passport-saml.svg)](http://badge.fury.io/js/passport-saml) [![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
[![Build Status](https://github.com/node-saml/passport-saml/workflows/Build%20Status/badge.svg)](https://github.com/node-saml/node-saml/actions?query=workflow%3ABuild%Status)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is node-saml/passport-saml this should probably point to

https://github.com/node-saml/passport-saml/actions?query=workflow%3ABuild%Status

instead of

https://github.com/node-saml/node-saml/actions?query=workflow%3ABuild%Status

?


[![NPM](https://nodei.co/npm/passport-saml.png?downloads=true&downloadRank=true&stars=true)](https://nodei.co/npm/passport-saml/)
[![NPM](https://nodei.co/npm/@node-saml/passport-saml.png?downloads=true&downloadRank=true&stars=true)](https://nodei.co/npm/@node-saml/node-saml)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably point to

https://nodei.co/npm/@node-saml/passport-saml

instead of

https://nodei.co/npm/@node-saml/node-saml

?

@srd90
Copy link

srd90 commented Jun 27, 2022

Documentation at https://www.npmjs.com/package/@node-saml/passport-saml suggests to use npm install passport-saml instead of npm install @node-saml/passport-saml because this pull request's content is not present at latest version pushed to npmjs ( https://www.npmjs.com/package/@node-saml/passport-saml/v/4.0.0-beta.1 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants