Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onicecandidate fires on pc.close #624

Closed
arlolra opened this issue May 7, 2020 · 1 comment
Closed

onicecandidate fires on pc.close #624

arlolra opened this issue May 7, 2020 · 1 comment
Labels
bug good first issue

Comments

Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@arlolra @markandrus
@arlolra
Copy link
Contributor

@arlolra arlolra commented May 7, 2020 

var wrtc = require('wrtc');

var RTCPeerConnection = wrtc.RTCPeerConnection;

var pc = new RTCPeerConnection({
	iceServers: [{ urls: ['stun:stun.l.google.com:19302'] }]
});

pc.onicecandidate = function (evt) {
	console.log(evt);
};

pc.close();

This doesn't seem to happen browsers.
@markandrus markandrus added the bug label May 7, 2020
@markandrus
Copy link
Member

@markandrus markandrus commented May 7, 2020

Thanks for the report!

arlolra added a commit to arlolra/node-webrtc that referenced this issue May 7, 2020
@arlolra
Don't signal iceGatheringState complete if connection closed
e8f0d07 
This only happens internal to node-webrtc,
https://chromium.googlesource.com/external/webrtc/+/branch-heads/m79/pc/peer_connection.cc#4385

Fixes node-webrtc#624
@arlolra arlolra mentioned this issue May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment