Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't signal iceGatheringState complete if connection closed #625

Merged
merged 1 commit into from May 16, 2020
Merged

Don't signal iceGatheringState complete if connection closed #625

merged 1 commit into from May 16, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@arlolra @markandrus
@arlolra
Copy link
Contributor

@arlolra arlolra commented May 7, 2020

Note that, although this adds a test, I didn't actually try running it :)

This only happens internal to node-webrtc,
https://chromium.googlesource.com/external/webrtc/+/branch-heads/m79/pc/peer_connection.cc#4385
@arlolra
Don't signal iceGatheringState complete if connection closed
e8f0d07 
This only happens internal to node-webrtc,
https://chromium.googlesource.com/external/webrtc/+/branch-heads/m79/pc/peer_connection.cc#4385

Fixes node-webrtc#624
@arlolra
Copy link
Contributor Author

@arlolra arlolra commented May 7, 2020

Fixes #624

@markandrus
Copy link
Member

@markandrus markandrus commented May 7, 2020

Really nice, @arlolra — thank you. I will try to merge this sometime soon. As you may have noticed, the WebRTC build process has changed (again) and so builds are now failing. I'll need to get that working again first.

@markandrus markandrus merged commit 789d0f2 into node-webrtc:develop May 16, 2020
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment