Connection::onEnd issue #47

Closed
wants to merge 1 commit into from

2 participants

@superfeedr

Hello Stephan,

I found an issue in node-xmpp. As we've discussed in the past, I think it is better to decouple the Connection from the Socket, so that we can use other types of "socket" to support connection : namely websockets, but also stuff like Bosh for example (if we can ever port node-xmpp to th browser)...
Right now, it assumes that when the socket triggers the 'end' event, it still exist as an object... which doesn't seem to the case for websockets.

Let me know if that makes any sense!

Julien

@superfeedr

Forget this please... I find a more elegant solution :) It would be nice that the API on the socket that is being used by the connection is documented though!

@superfeedr superfeedr closed this Nov 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment