Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Variable username doesn't exist #50

Closed
wants to merge 1 commit into from

2 participants

@frane

Hi,

A bug in c2s causes the registration to fail and crash because a variable "username" is accessed that doesn't exit. This one line patch should fix it.

@frane

This pull request can be ignored since #52 includes this fix.

@frane frane closed this
@astro
Owner

I see you're located in Berlin. Will I be meeting you at 28C3 next tuesday?

@frane

Unfortunately, this year I'll only have time to be there on Thursday.

@astro
Owner

Great! I hope you'll get a day ticket.

@frane

I hope being there extra early helps :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 23, 2011
  1. @frane

    Variable username doesn't exist

    frane authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/xmpp/c2s.js
View
2  lib/xmpp/c2s.js
@@ -211,7 +211,7 @@ C2SStream.prototype.onRegistration = function(stanza) {
else if (stanza.attrs.type === 'set') {
var jid = new JID(register.getChildText('username'), this.server.options.domain)
self.server.emit('register', { jid: jid,
- username: username,
+ username: register.getChildText('username'),
password: register.getChildText('password'),
client: self },
function(error) {
Something went wrong with that request. Please try again.