Linking registration reply to callback #92

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

On receiving a registration stanza we enter C2SStream.prototype.onRegistration and we were sending success reply for stanza.attrs.type === 'set' case delinking it to the value of 'error' in the callback to 'register' event.
Making self.send(reply) part of callback mitigates this bug. 

@kartikrustagi kartikrustagi Linking registration reply to callback
On receiving a registration stanza we enter C2SStream.prototype.onRegistration and we were sending success reply for stanza.attrs.type === 'set' case delinking it to the value of 'error' in the callback to 'register' event.
Making self.send(reply) part of callback mitigates this bug. 
2b4d6ff
Owner

It looks like this is already implemented in lib/xmpp/c2s.js` so I am closing this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment