Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix item name/prefix for events of nested sections/namespaces/classes #63

Merged
merged 2 commits into from Jul 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

Sannis commented Jul 22, 2012

Node id should be composed before all indexOf operations on it

@Sannis Sannis Fix item name/prefix for events of nested namespaces
Node id should be composed before all indexOf operations on it
63b31fa
Owner

puzrin commented Jul 26, 2012

I need 2 things to approve this commit:

  1. Example on prototype sources from ./test/prototype folder . If exists. And confirmation, that patch will not break existing result for prototype events doc
  2. Test sample here https://github.com/nodeca/ndoc/tree/master/tests/features , that demonstrates your case
Contributor

Sannis commented Jul 26, 2012

Sure, I'll add them.

2012/7/26 Vitaly Puzrin
reply@reply.github.com:

I need 2 things to approve this commit:

  1. Example on prototype sources from ./test/prototype folder . If exists. And confirmation, that patch will not break existing result for prototype events doc
  2. Test sample here https://github.com/nodeca/ndoc/tree/master/tests/features , that demonstrates your case

Reply to this email directly or view it on GitHub:
#63 (comment)

Best regards,
Oleg "Sannis" Efimov

http://sannis.ru

Contributor

Sannis commented Jul 26, 2012

Unfortunately, there is no events in Prototype.

I'll add a test case for features folder as second commit.

Before this patch:

After this patch:

@puzrin puzrin added a commit that referenced this pull request Jul 28, 2012

@puzrin puzrin Merge pull request #63 from Sannis/fix-events-names
Fix item name/prefix for events of nested sections/namespaces/classes
87a0ce8

@puzrin puzrin merged commit 87a0ce8 into nodeca:master Jul 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment