Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version picker in conjunction with nodecg/nodecg#415 #3

Open
wants to merge 6 commits into
base: master
from

Conversation

@Dan-Shields
Copy link

commented Jul 16, 2019

Adds new element at bottom of navbar to enable the user to pick a different version of the docs to view.

Populates version list with a .json file created in the new nodecg/nodecg#415 script.

@Hoishin

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I wonder if we have to support IE11, because if not, we could use fetch which is easier to handle than raw XHR.

@Dan-Shields

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

If the current solution is good enough I think it's not a bad idea to keep support up for as many browsers as possible.

I don't 100% know if it is though, as you can see from the boilerplate comments I accidentally left in I don't normally do anything in vanilla js and just found something that worked 😅

@Lange

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.