New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundles): support loading dashboard assets from node_modules #358

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Projects
None yet
2 participants
@haganbmj
Contributor

haganbmj commented Dec 25, 2017

The bower test constant doesn't appear to have a use either.

@Lange

This comment has been minimized.

Show comment
Hide comment
@Lange

Lange Dec 25, 2017

Member

Thanks! And yeah when I ported all the tests from Mocha to AVA I had to get rid of some of them because I just didn't have the time/patience to re-write them. The bower serving tests were some of those.

Member

Lange commented Dec 25, 2017

Thanks! And yeah when I ported all the tests from Mocha to AVA I had to get rid of some of them because I just didn't have the time/patience to re-write them. The bower serving tests were some of those.

@Lange Lange merged commit 74915d7 into nodecg:master Dec 25, 2017

1 of 3 checks passed

Node Security 4 vulnerabilities found
Details
coverage/coveralls Coverage decreased (-0.4%) to 71.126%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@haganbmj haganbmj deleted the haganbmj:dashboard-node-modules branch Dec 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment