New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more types in browser.d.ts #465

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@Dan-Shields
Copy link
Contributor

Dan-Shields commented Feb 7, 2019

Export NodeCGStaticBrowser and NodeCGBrowser directly, as well as providing global constants for the two named NodeCG and nodecg respectively.

@Lange Lange requested a review from Hoishin Feb 7, 2019

@Lange

Lange approved these changes Feb 7, 2019

Copy link
Member

Lange left a comment

LGTM, will let @Hoishin have the final say.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #465 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #465     +/-   ##
=========================================
+ Coverage   91.13%   91.23%   +0.1%     
=========================================
  Files          62       62             
  Lines        2933     2933             
=========================================
+ Hits         2673     2676      +3     
+ Misses        260      257      -3
Impacted Files Coverage Δ
lib/assets/index.js 85% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d7511...a11a171. Read the comment docs.

@Hoishin

Hoishin approved these changes Feb 8, 2019

@Hoishin Hoishin merged commit 0455036 into nodecg:master Feb 8, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 50d7511...a11a171
Details
codecov/project 91.23% (+0.1%) compared to 50d7511
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment