Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL conflict with node 6.3 #1077

Open
maxkorp opened this issue Jul 19, 2016 · 10 comments
Open

OpenSSL conflict with node 6.3 #1077

maxkorp opened this issue Jul 19, 2016 · 10 comments

Comments

@maxkorp
Copy link
Collaborator

maxkorp commented Jul 19, 2016

So we need to bump OpenSSL to the latest x.2 anyways (I believe its h), but as of node 6.3, some sort of exports in windows are conflicting with our OpenSSL bundling.

In order to get PRs running again I've temporarily capped all builds at 6.2 here: 7cfcf99

@implausible and I are going to try to bump OpenSSL and if that doesn't fix it, we'll dive into what exports are conflicting so we can get builds back on track

@johnhaley81
Copy link
Collaborator

@maxkorp @implausible what did you guys find out?

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 10, 2016

Haven't gotten to touch this :/

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

Very much related: nodejs/node#7608
This is going to end up with some bizarre gypfile tomfoolery

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

Does not look good, in particular related to electron >.<
nodejs/node-gyp#874

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

Ooh, possibly related
electron/electron@e8c03f2

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

Ha, that worked!
Edit: false

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

So bumping openssl actually breaks node 0.12 though. I'll make an issue for that

@maxkorp maxkorp closed this as completed Aug 12, 2016
@maxkorp maxkorp reopened this Aug 12, 2016
@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 12, 2016

Also related
nodejs/node#4932

@maxkorp
Copy link
Collaborator Author

maxkorp commented Aug 18, 2016

nodejs/help#254
image

@algv
Copy link

algv commented Nov 9, 2016

This 6822634 improve build. Or it is not full correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants