Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libgit2 to 43275f512ef888a14c43bde8007251ce595be32a + unmerged proxy fixes #1223

Merged
merged 6 commits into from Feb 28, 2017

Conversation

srajko
Copy link
Collaborator

@srajko srajko commented Feb 14, 2017

No description provided.

@rcjsuen
Copy link
Member

rcjsuen commented Feb 15, 2017

Bumping libgit2 to master would also fix #1220. Keep in mind though that things are a little fishy there since the test suite crashes but the builds are green...

@srajko
Copy link
Collaborator Author

srajko commented Feb 16, 2017

@rcjsuen in which builds are you seeing the tests crash?

@rcjsuen
Copy link
Member

rcjsuen commented Feb 16, 2017

@srajko Take a look at the AppVeyor and Travis CI builds that got spawned off for #1220. While AppVeyor is correctly red, Travis CI is green even though the test suite has segfaulted... :(

@srajko
Copy link
Collaborator Author

srajko commented Feb 16, 2017

That is indeed fishy :-) Thanks for pointing that out, definitely something we should resolve.

@tommoor
Copy link

tommoor commented Feb 17, 2017

0.17.0 is also crashing our test suites, I'm not sure why as karma disconnects with no result - subscribing to this in the hope that this will fix our woes when merged!

@srajko srajko changed the title Bump libgit2 to master + unmerged proxy fixes Bump libgit2 to 43275f512ef888a14c43bde8007251ce595be32a + unmerged proxy fixes Feb 24, 2017
@johnhaley81
Copy link
Collaborator

@srajko this needs a rebase now :(

@johnhaley81
Copy link
Collaborator

Well, everything is green except for the 32-bit linux builds which aren't really related to this PR and are fixed in #1241 so I'll admin merge this. Thanks @srajko

@johnhaley81 johnhaley81 merged commit 6b1f73b into nodegit:master Feb 28, 2017
@johnhaley81 johnhaley81 deleted the bump-libgit branch February 28, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants