Error constants added #25

Closed
wants to merge 2 commits into
from

3 participants

@milani

Fixes #23

Standard libgit2 error constants attached to Error object.

An outdated example fixed.

@tbranyen
NodeGit member

Whats the reason for this change here? Did the existing implementation not work as expected?

Both lines does not work! I should send another pull request. it should be:

master.lookup( repo , .....);

lookupRef does exists and also repo.lookup needs an extra argument.

NodeGit member

Okay lets try and figure this out before I merge this request. I don't think another pull req is necessary. Lets just add commits to this branch.

Sorry But I pushed another commit to fix this example.

@tbranyen
NodeGit member

@milani thats fine that commit showed up in this pull as well.

@faceleg

Excuse me for asking a likely obvious question - this will make the actual error available on the error object like (?):

console.log(error.strError);

Yes.

@faceleg

Thanks for this!

Would you please update the tests to include some that cover these changes? Then we can look at merging this in.

@faceleg faceleg referenced this pull request Feb 27, 2013
Closed

Issue with errors #23

@milani

Sorry but this is for a year ago. I can not remember the details:)

@milani milani closed this Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment