Removed references to node_events.h #31

wants to merge 1 commit into


None yet

4 participants

It looks to me like this solves the compilation problem through 0.5.3 that was caused by the removal of node_events.h from node.js. Same tests pass/fail before and after this change.

So with these references removed, the application compiles successfully under node 0.5?


Pretty sure this pull request resolves the aforementioned issue on node > 0.5.3: #30

jmendeth commented Aug 9, 2012

When you include node.h, all the other Node headers are also included.
No need to include both node.h and node_object_wrap.h.

Update: Just noticed that only object_wrap and other internals are included.

faceleg commented Feb 27, 2013

Project compiles on ~0.8, closing.

@faceleg faceleg closed this Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment