Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Removed references to node_events.h #31

Closed
wants to merge 1 commit into from

4 participants

Alex Wolfe Xavier Mendez Michael Robinson Tim Branyen
Alex Wolfe

It looks to me like this solves the compilation problem through 0.5.3 that was caused by the removal of node_events.h from node.js. Same tests pass/fail before and after this change.

Tim Branyen
Owner

So with these references removed, the application compiles successfully under node 0.5?

Alex Wolfe

Pretty sure this pull request resolves the aforementioned issue on node > 0.5.3: #30

Xavier Mendez

When you include node.h, all the other Node headers are also included.
No need to include both node.h and node_object_wrap.h.

Update: Just noticed that only object_wrap and other internals are included.

Michael Robinson

Project compiles on ~0.8, closing.

Michael Robinson faceleg closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 26, 2011
  1. Alex Wolfe

    Removed references to node_events.h, which was unused. This is necess…

    alexkwolfe authored
    …ary for Node 0.5.x compatibility.
This page is out of date. Refresh to see the latest.
4 include/commit.h
View
@@ -8,7 +8,7 @@
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
@@ -23,7 +23,7 @@ using namespace v8;
/**
* Class wrapper for libgit2 git_commit
*/
-class GitCommit : public EventEmitter {
+class GitCommit : public ObjectWrap {
public:
/**
* v8::FunctionTemplate used to create Node.js constructor
2  include/error.h
View
@@ -7,7 +7,7 @@
#define ERROR_H
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
3  include/index.h
View
@@ -7,8 +7,7 @@
#define INDEX_H
#include <node.h>
-#include <node_events.h>
-
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
using namespace node;
4 include/object.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
@@ -19,7 +19,7 @@ using namespace node;
/**
* Class wrapper for libgit2 git_object
*/
-class GitObject : public EventEmitter {
+class GitObject : public ObjectWrap {
public:
/**
* v8::FunctionTemplate used to create Node.js constructor
2  include/odb.h
View
@@ -7,7 +7,7 @@
#define ODB_H
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  include/odb_backend.h
View
@@ -7,7 +7,7 @@
#define ODB_BACKEND_H
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
4 include/oid.h
View
@@ -7,14 +7,14 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
using namespace node;
using namespace v8;
-class GitOid : public EventEmitter {
+class GitOid : public ObjectWrap {
public:
static Persistent<FunctionTemplate> constructor_template;
static void Initialize (Handle<v8::Object> target);
4 include/reference.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include <string>
#include "../vendor/libgit2/include/git2.h"
@@ -18,7 +18,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
using namespace node;
using namespace v8;
-class GitReference : public EventEmitter {
+class GitReference : public ObjectWrap {
public:
static Persistent<FunctionTemplate> constructor_template;
static void Initialize(Handle<v8::Object> target);
4 include/repo.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include <string>
#include "../vendor/libgit2/include/git2.h"
@@ -17,7 +17,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
using namespace node;
using namespace v8;
-class GitRepo : public EventEmitter {
+class GitRepo : public ObjectWrap {
public:
static Persistent<FunctionTemplate> constructor_template;
static void Initialize(Handle<v8::Object> target);
4 include/revwalk.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
@@ -17,7 +17,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
using namespace node;
using namespace v8;
-class GitRevWalk : public EventEmitter {
+class GitRevWalk : public ObjectWrap {
public:
static Persistent<FunctionTemplate> constructor_template;
static void Initialize(Handle<v8::Object> target);
4 include/sig.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
@@ -16,7 +16,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
using namespace v8;
using namespace node;
-class GitSig : public EventEmitter {
+class GitSig : public ObjectWrap {
public:
static Persistent<FunctionTemplate> constructor_template;
static void Initialize(Handle<v8::Object> target);
2  include/tag.h
View
@@ -7,7 +7,7 @@
#define TAG_H
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
4 include/tree.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include <string>
#include "../vendor/libgit2/include/git2.h"
@@ -21,7 +21,7 @@ using namespace node;
/**
* Class wrapper for libgit2 git_tree
*/
-class GitTree : public EventEmitter {
+class GitTree : public ObjectWrap {
public:
/**
* v8::FunctionTemplate used to create Node.js constructor
4 include/tree_entry.h
View
@@ -7,7 +7,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
@@ -22,7 +22,7 @@ using namespace node;
/**
* Class wrapper for libgit2 git_tree_entry
*/
-class GitTreeEntry : EventEmitter {
+class GitTreeEntry : ObjectWrap {
public:
/**
* v8::FunctionTemplate used to create Node.js constructor
2  src/base.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/commit.cc
View
@@ -6,7 +6,7 @@
#include <string.h>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/error.cc
View
@@ -5,7 +5,7 @@
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/object.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/oid.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/reference.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include <string>
#include "../vendor/libgit2/include/git2.h"
2  src/repo.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include <string>
#include "../vendor/libgit2/include/git2.h"
2  src/revwalk.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/sig.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/tree.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
2  src/tree_entry.cc
View
@@ -4,7 +4,7 @@ Copyright (c) 2011, Tim Branyen @tbranyen <tim@tabdeveloper.com>
#include <v8.h>
#include <node.h>
-#include <node_events.h>
+#include <node_object_wrap.h>
#include "../vendor/libgit2/include/git2.h"
Something went wrong with that request. Please try again.