Define GIT_SSH_MEMORY_CREDENTIALS for libgit2

[alantrrs]

Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.

Fixes #760

[alantrrs]

This is just a rebase of #763 . However it seems like tests are still failing.

[alantrrs]

Rebased again. However it looks like the version of libssh2 used here is not updated since it doesn't include libssh2_userauth_publickey_frommemory. See build

Any plans to update it?

[johnhaley81]

We could update libssh2 in a different PR.

[richardkazuomiller]

Is there any status update on this and/or updating libssh2? I'd like to use sshKeyMemoryNew. I'm not good enough at C to figure out how to contribute at all though, sorry (^^ゞ

[jamon]

This definitely works with libssh2 1.7.0. I'm happy to walk through the steps to get it working, below, but I'm not familiar enough with node-gyp and nodegit's build process to do it in a pull-request worthy way.

checkout the latest nodegit code and do the following (only tested on linux):

• remove vendor/libssh2 entirely and commit this
• cd vendor ; git clone -b tags/libssh2-1.7.0 https://github.com/libssh2/libssh2.git (this could be done as a submodule if you'd like)
• cd libssh2 ; ./buildconf
• cd ../.. ; npm install
• sudo npm link -g
• add "GIT_SSH_MEMORY_CREDENTIALS" to the "defines" array for libgit2 (part of this pull request shows this part)

use the globally installed nodegit from your projects

[maxkorp]

@jamon which OS were you testing on though? I've got a pr here: #1071

But it dies for windows

[maxkorp]

Up to date! @alantrrs care to rebase on top of master?

[alantrrs]

rebased

[maxkorp]

Nice, TY

[kid]

Any changes to see this in a new release soon?
I'm trying to install from master but I'm facing other issues

Thanks!