Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make contributions (adding features, methods etc)? #36

Closed
Uriziel01 opened this issue Aug 21, 2019 · 4 comments

Comments

@Uriziel01
Copy link
Contributor

commented Aug 21, 2019

Hi,
I'm exploring this project right now and I have to say its pretty frickin awesome 馃憤

I would like to evaluate it as a platform for my next project and was wondering how could I tacke moving with mouse/changing position of a window with WindowType.FramelessWindowHint flag (as used in weather widget example)?

The setGeometry/move seems to be lacking implementation? Or I'm just simply missing something?

Ohhh! And sorry for using issue tracker as a community board but I did not see any other communication channel available.

@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Yes, I setGeometry/move are not yet implemented. Maybe you can raise a PR for the same ?

And regarding using issue tracker as a community board, i think thats perfectly fine. Issue tracker would prove as a searcheable location for finding stuff.

You can get started following the contributors guide or maybe looking around the codebase.
And in any doubt you can ping back here and I ll be happy to help. @Uriziel01

@Uriziel01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@master-atul just to be sure, would it be sufficient workflow if I would (in my test project) go into node-modules/@nodegui/nodegui/ and after adding setGeometry method into appropriate files (in this case in src/cpp/QtWidgets/QWidget/qwidget_macro.h and src/lib/QtGui/QWidget/index.ts) and just rebuilding it there with npm run build?

I have to say I would love to contribute in this project but feel a little bit intimidated with the whole installing QT (which is apparently 3.7G in size) and rebuilding Qode process.

EDIT:
I just checked it and just like that setGeometry method was implemented as is working as intended, will work on a proper PR tomorrow :)

@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Hi @Uriziel01 You could basically clone @nodegui/nodegui repo and then
add a test inside demo.ts file.

You can run this demo.ts using npm run dev.

Lets say you wanted to add
widget.move

you could add a test in demo.ts file as

const widget = new QWidget();
widget.move(500,300);

Then run the file as npm run dev.

Then basically work your way backwards by adding the correct implementation inside qwidget_macro and qwidget/index.ts


And you dont need to install Qt nor build Qode from scratch. The prebuilt binaries are installed when you do npm install. also Qt include headers and dlls are also installed when @nodegui/qode is installed.

@master-atul master-atul changed the title Is Frameless window missing move method? How to make contributions (adding features, methods etc)? Aug 22, 2019
@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

For future contributors:
This PR can be used as a reference to contributors who are starting. It is precise and contains exactly what is needed to get started. #39

Special thanks to @Uriziel01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.