Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it currently possible to get a QCheckBox's checked state? #66

Closed
jameshibbard opened this issue Aug 26, 2019 · 4 comments
Closed

Is it currently possible to get a QCheckBox's checked state? #66

jameshibbard opened this issue Aug 26, 2019 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jameshibbard
Copy link
Contributor

In NodeGUI is it currently possible to get a QCheckBox's checked state?

In QT you can use isChecked() to query whether or not a checkbox is checked, but I could find no reference to this or anything similar in the NodeGUI docs or code base.

Also, is this a good place to ask questions? If not, could you please tell me where is.

I'm currently converting an small FXRuby app to use NodeGUI just to see how the two stack up against each other. I've run into one or two issues, but don't want to spam the repo.

@a7ul
Copy link
Collaborator

a7ul commented Aug 26, 2019

Hi @jameshibbard Yes this is the right place to ask questions.
No the function is not yet exported in NodeGUI.

But, isChecked seems to be pretty straightforward. Let me just add it and release a new version.

@a7ul a7ul added enhancement New feature or request question Further information is requested labels Aug 26, 2019
@a7ul
Copy link
Collaborator

a7ul commented Aug 26, 2019

This PR adds support for the checkbox methods you needed @jameshibbard #67

Feel free to take a look at this and implement more methods that you need and maybe raise a PR?
You can always ask more questions here.

@a7ul
Copy link
Collaborator

a7ul commented Aug 26, 2019

Alright, the changes are in https://github.com/nodegui/nodegui/releases/tag/v0.1.6

@a7ul a7ul closed this as completed Aug 26, 2019
@jameshibbard
Copy link
Contributor Author

Thank you very much for the quick turn around. I really appreciate that!

Feel free to take a look at this and implement more methods that you need and maybe raise a PR?

My C++ knowledge is not great, I'm afraid, which is frustrating, as I would like to help. Saying that, I'll give the contributor’s guide a read and see if I can make sense of things.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants