Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting orientation inside progressbar widget #39

Merged
merged 4 commits into from Aug 22, 2019

Conversation

@Uriziel01
Copy link
Contributor

@Uriziel01 Uriziel01 commented Aug 22, 2019

It's also a first pull request to validate my workflow is in fact valid for further development.

rgabs
rgabs approved these changes Aug 22, 2019
@a7ul
Copy link
Collaborator

@a7ul a7ul commented Aug 22, 2019

Wow!
One tiny addition,
I would also add Orientation to the exports here: https://github.com/nodegui/nodegui/blob/master/src/index.ts
@Uriziel01

@Uriziel01
Copy link
Contributor Author

@Uriziel01 Uriziel01 commented Aug 22, 2019

@master-atul Ohhh I overlooked that part, thanks for pointing it out, I've made the change 👍

@a7ul
Copy link
Collaborator

@a7ul a7ul commented Aug 22, 2019

Merging this. Will go out in next release 🍺

@a7ul a7ul merged commit 2011d51 into nodegui:master Aug 22, 2019
@a7ul
Copy link
Collaborator

@a7ul a7ul commented Aug 22, 2019

@all-contributors please add @Uriziel01 for code

@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Aug 22, 2019

@master-atul

I've put up a pull request to add @Uriziel01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants