Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting orientation inside progressbar widget #39

Merged
merged 4 commits into from Aug 22, 2019

Conversation

@Uriziel01
Copy link
Contributor

commented Aug 22, 2019

It's also a first pull request to validate my workflow is in fact valid for further development.

@Uriziel01 Uriziel01 force-pushed the Uriziel01:master branch from 6696b82 to a05181a Aug 22, 2019
@rgabs
rgabs approved these changes Aug 22, 2019
@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

Wow!
One tiny addition,
I would also add Orientation to the exports here: https://github.com/nodegui/nodegui/blob/master/src/index.ts
@Uriziel01

@Uriziel01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@master-atul Ohhh I overlooked that part, thanks for pointing it out, I've made the change 👍

@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

Merging this. Will go out in next release 🍺

@master-atul

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

@all-contributors please add @Uriziel01 for code

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@master-atul

I've put up a pull request to add @Uriziel01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.