Skip to content
This repository

closes #164 and #235 fix wrong usage of matchBase option of minimatch, use relative to watchDirectory path for matching #274

Closed
wants to merge 1 commit into from

2 participants

Oleg Slobodskoi Charlie McConnell
Oleg Slobodskoi
kof commented

This has fixed the issue for me.

Oleg Slobodskoi kof closes #164 and #235 fix wrong usage of matchBase option of minimatch…
…, use relative to watchDirectory path fore matching
1a478ba
Oleg Slobodskoi
kof commented

however console.error( minimatch('tmp/public/app/css/main.css', 'tmp/*', { matchBase: true })); // false

I think minimatch is somehow broken.

Oleg Slobodskoi
kof commented

ok its my fault

isaacs/minimatch#8

Charlie McConnell

Cherry-picked in 44c2337 - thanks!

For future reference, we tend to lump groups of changes together into releases - as such, I removed the version bump from your commit. I'll be bumping and publishing 0.9.1 after a little bit more testing later today.

Charlie McConnell AvianFlu closed this
Oleg Slobodskoi
kof commented

Well, if I understand correctly semver, patch number should be increased if any public functionality was changed. This is the case here so, I don't really understand why do you want to group changes. Publishing a new version doesn't cost money and there are enough numbers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 04, 2012
Oleg Slobodskoi kof closes #164 and #235 fix wrong usage of matchBase option of minimatch…
…, use relative to watchDirectory path fore matching
1a478ba
This page is out of date. Refresh to see the latest.

Showing 2 changed files with 6 additions and 4 deletions. Show diff stats Hide diff stats

  1. +4 2 lib/forever/plugins/watch.js
  2. +2 2 package.json
6 lib/forever/plugins/watch.js
@@ -18,8 +18,10 @@ function watchFilter(fileName) {
18 18 return false;
19 19 }
20 20
  21 + fileName = path.relative(this.watchDirectory, fileName);
  22 +
21 23 for (var key in this.watchIgnorePatterns) {
22   - if (minimatch(fileName, this.watchIgnorePatterns[key], { matchBase: this.watchDirectory })) {
  24 + if (minimatch(fileName, this.watchIgnorePatterns[key], { matchBase: true })) {
23 25 return false;
24 26 }
25 27 }
@@ -53,4 +55,4 @@ exports.attach = function () {
53 55 }
54 56 }
55 57 });
56   -};
  58 +};
4 package.json
@@ -2,7 +2,7 @@
2 2 "name": "forever",
3 3 "preferGlobal": "true",
4 4 "description": "A simple CLI tool for ensuring that a given node script runs continuously (i.e. forever)",
5   - "version": "0.9.0",
  5 + "version": "0.9.1",
6 6 "author": "Nodejitsu Inc <info@nodejitsu.com>",
7 7 "contributors": [
8 8 { "name": "Charlie Robbins", "email": "charlie@nodejitsu.com" },
@@ -28,7 +28,7 @@
28 28 "daemon": "https://github.com/AvianFlu/daemon.node/tarball/master",
29 29 "flatiron": "0.1.x",
30 30 "microtime": "0.2.x",
31   - "minimatch": "0.0.x",
  31 + "minimatch": "0.2.x",
32 32 "nconf": "0.5.x",
33 33 "nssocket": "0.3.x",
34 34 "node-fork": "0.4.x",

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.