New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to listen on unix sockets #34

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jcrugzz
Copy link
Member

jcrugzz commented Feb 15, 2013

Implements #20. I have been working on the tests but I wanted to ask if there is a good way to test the unix socket case without creating more and more unix.sock files in the directory. First time dealing with them. @mmalecki thoughts?

@@ -158,6 +173,11 @@ Client.prototype.connect = function (port, host, callback) {
callback();
}
}
else if (this.type === 'unix') {
this.socket = new net.Socket({type: 'unix' });
this.socket.setEncoding('utf8');

This comment has been minimized.

@blakmatrix

This comment has been minimized.

@blakmatrix

blakmatrix Feb 15, 2013

might be a good chance to utilize options.encoding

This comment has been minimized.

@jcrugzz

jcrugzz Feb 15, 2013

Author Member

hmm I suppose not. I was just following what was done for TCP.

@jcrugzz

This comment has been minimized.

Copy link
Member Author

jcrugzz commented Feb 26, 2013

Thanks to a little help from @blakmatrix I got the tests working for the unix sockets.

@indexzero

This comment has been minimized.

Copy link
Member

indexzero commented Mar 9, 2013

Cherry-picked. Thanks!

@indexzero indexzero closed this Mar 9, 2013

@jcrugzz jcrugzz deleted the jcrugzz:unix-sockets branch Mar 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment