Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] implement recombine option #54

Merged
merged 3 commits into from Jun 14, 2013

Conversation

Projects
None yet
2 participants
@jcrugzz
Copy link
Member

commented Jun 12, 2013

@indexzero make sure I'm sane here but this should work.

@mmalecki

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2013

Force-pushed to include 20bd2c9 (was a pain when writing tests).

@mmalecki

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2013

@jcrugzz I tried writing a test for this one in 34de2c7 and it seems to fail for me. Can you fix the code/test (test should be fine though, to the best of my knowledge)?

@jcrugzz

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2013

@mmalecki yea i'll see whats going on with it.

mmalecki added a commit that referenced this pull request Jun 14, 2013

Merge pull request #54 from nodejitsu/by-recombine
[api] implement recombine option

@mmalecki mmalecki merged commit 399f826 into master Jun 14, 2013

@mmalecki mmalecki deleted the by-recombine branch Jun 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.