Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[v0.6] Make C++ addon v0.6-compatible #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mmalecki commented Oct 11, 2011

@bmeck Review?

[v0.6] Make C++ addon v0.6-compatible
  * include `uv.h` instead of `ev.h`
  * use `uv_unref` and `uv_ref` with `uv_default_loop()` parameter (node
    uses default loop, as per
    http://nodejs.org/docs/v0.5.9/api/addons.html )
Owner

indexzero commented Oct 12, 2011

Is this backwards compatible to v0.4.x?

Contributor

mmalecki commented Oct 12, 2011

It is - it compiles and passes tests on v0.4.x. However, I'll do some extended tests today on VMs - I'm not sure if nvm is the right tool for testing compiled addons.

Contributor

bmeck commented Oct 12, 2011

No it is not, it will appear to be if you have installed a Node that
depends on uv.h and puts the includes into /usr/local/includes ,
however 0.4.x does not ship with uv.h.

On Tue, Oct 11, 2011 at 10:49 PM, Charlie Robbins
reply@reply.github.com
wrote:

Is this backwards compatible to v0.4.x?

Reply to this email directly or view it on GitHub:
#12 (comment)

Contributor

mmalecki commented Oct 12, 2011

@bmeck You're right, sorry about that. (It appears that when building under nvm, headers from /usr/local/include are still being used, that's probably why I've assumed that it builds just fine).

Contributor

bmeck commented Oct 25, 2011

fixed in v0.2.8, added libuv detection to your patch.

@bmeck bmeck closed this Oct 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment