Skip to content

[refactor v0.6] Refactor `net` module #17

Merged
merged 1 commit into from Nov 28, 2011

2 participants

@mmalecki
mmalecki commented Nov 6, 2011

Changes:

  • monkey-patch _listen2 instead of _doListen
  • get rid of process.binding('net'), it was removed
  • remove part responsible for getting dummy file descriptor

Please note that this breaks compatibility with node v0.4. If we're going to take this patch, I would propose creating maintenance branch v0.2, merging this pull request into master, bumping master's version to v0.3.0 and moving on with development.

@mmalecki mmalecki [refactor v0.6] Refactor `net` module
Changes:

  * monkey-patch `_listen2` instead of `_doListen`
  * get rid of `process.binding('net')`, it was removed
  * remove part responsible for getting dummy file descriptor
d2b6789
@bmeck bmeck merged commit d8c5017 into master Nov 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.