Remove "carapace has wrapped" message #22

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

In the context of haibu and nodejitsu, the "carapace has wrapped" message is confusing and out-of-context. This commit simply removes the notification from haibu-carapace, since it appears to be for logging/debug purposes only.

Owner

+1 in principle, but @jesusabdullah Can you confirm the tests are passing with this? I'm not seeing them pass.

$ npm test
(...)
♢ carapace/run/process

  When using haibu-carapace and spawning /.server.js in a separate process
    ✓ should respond with the proper wrapped script output
  When using haibu-carapace and spawning /.server.js in a separate process should correctly start the HTTP server
    ✗ that responds with a cwd inside the chroot jail
      » expected null, got {
    message: 'connect ECONNREFUSED',
    stack: 'Error: connect ECONNREFUSED\n    at errnoException (net.js:642:11)\n    at Object.afterConnect [as oncomplete] (net.js:633:18)',
    code: 'ECONNREFUSED',
    arguments: undefined,
    errno: 'ECONNREFUSED',
    syscall: 'connect',
    type: undefined
} // net.js:642
jfhbrook commented May 9, 2012

iirc all tests that passed without this change passed with this change as well. I certainly don't remember this one.

I can certainly double check though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment