Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Improve update checking logic #226
This approach is not adequate. If you read the code, you'll see that we are checking npm with a
This is problematic for a couple reasons:
We should periodically perform the update check, and probably move all this logic to Flatiron.
Just checked up on this. The process is still exactly the same, though the code in question is now https://github.com/nodejitsu/jitsu/blob/master/lib/jitsu/common/index.js#L167-207 a few lines down.
I agree that this logic should be in a separate plugin, and that there has to be a smarter way to check for this.
@pksunkara Do you have any ideas for this? Want to give it a shot? Lemme know, we'll talk about it.