devDependencies are *sometimes* installed in production mode #298

Closed
hlobil opened this Issue Aug 24, 2012 · 7 comments

Comments

Projects
None yet
7 participants

hlobil commented Aug 24, 2012

It appears that my deployments are failing when I have devDependencies in the package.json. I renamed it to devDependenciesOld and it deploys fine.

Note similar issue may have been fixed in haibu, but not sure which component of nodejitsu is responsible.

nodejitsu/haibu#104

Pavel

changing it to something like NODE_ENV=production npm install may work

Contributor

Marak commented Aug 31, 2012

Is this still happening? Can you confirm your ENV variable NODE_ENV on Nodejitsu?

It should be set to production by default.

Type: jitsu env list

Contributor

blakmatrix commented Aug 31, 2012

Marak,

even though default env is set to "production" whatever is in dev dependencies will get installed. @AvianFlu knows more, but this issue will be phased out soon and i think the direct we will take is to never install devDependencies

Contributor

jfhbrook commented Sep 24, 2012

My understanding is that, while this is typically not an issue, that some dependencies (possibly grunt-contrib) may be able to override this setting.

Contributor

blakmatrix commented Sep 25, 2012

This is still an issue, devDependencies items get installed for any 1+ dependencies in the dependencies field, the devDependencies dont get installed on the bundle server, but get passed along to the drone in which the drone installs them

contra commented Sep 27, 2012

I'm also experiencing this issue. Renaming devDependencies allows the deploy to run without issues. Looking at the haibu code it seems to be running with NODE_ENV=production and --production so I don't understand why NPM is doing it anyways

+1

Ditto. Had to delete devDependencies to get my deploy to work without a socket hangup.

@ghost ghost assigned mmalecki Oct 27, 2012

Contributor

blakmatrix commented Feb 3, 2013

This has been fixed with a patch to nodejitsu drones.

@blakmatrix blakmatrix closed this Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment