Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

do not allow domain names with - as a starting/ending character #361

Closed
tmpvar opened this Issue Nov 20, 2012 · 6 comments

Comments

Projects
None yet
4 participants

@yawnt yawnt referenced this issue Nov 21, 2012

Closed

Fix for subdomain #362

Contributor

blakmatrix commented Jan 8, 2013

The labels must follow the rules for ARPANET host names.  They must
start with a letter, end with a letter or digit, and have as interior
characters only letters, digits, and hyphen.  There are also some
restrictions on the length.  Labels must be 63 characters or less.

apparently a user used [ in setting there domain

Contributor

blakmatrix commented Feb 3, 2013

This is still an issue in jitsu, I'm not sure if this is because the changes made to the API havent been instantiated yet.

Contributor

jfhbrook commented Feb 3, 2013

jitsu should do this same validation regardless of the state of the upstream API.

Contributor

blakmatrix commented Mar 14, 2013

regex for this is ^[a-zA-Z]$|^[a-zA-Z][a-zA-Z\d]$|^[a-zA-Z][\w\-]{1,61}[a-zA-Z\d]$

Underscores allowed, except in host names, see RFC 2872

Contributor

Southern commented Mar 16, 2013

@blakmatrix Is this fixed? Can we close it?

Contributor

blakmatrix commented Mar 16, 2013

yup

@blakmatrix blakmatrix closed this Mar 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment