Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

node v0.10.x support #405

Closed
blakmatrix opened this Issue · 8 comments

6 participants

@blakmatrix

With the release of the new version of node we see some new issues wit the jitsu tool.

A few I have encountered so far:

We get Hostname/IP doesn't match certificate's altnames when trying to authenticate when remoteHost is set to api.jit.su or api.jitsu.com and I suspect direct IPs as well. A "work around" is to use jitsu host api.nodejitsu.com.

Calling jitsu fails with https://gist.github.com/blakmatrix/5136225

On successful operations jitu sometimes hangs. This has happened for me on deploy and snapshots fetch.

Thats all I have for now.

@blakmatrix

One thing I did not mention but seems more prevalent is that there seems to be more unhandled errors. I feel perhaps this would be a good time to adress #380 #184

@julianduque

I began to work on the error handling issues and using errs to do this. We can work together on this since is a major feature / release. What do you think? I will submit the first PR this night

@PatrickHeneise

Getting in the 0.10-line:

    info:    Welcome to Nodejitsu me
    info:    jitsu v0.12.3, node v0.10.0
    info:    It worked if it ends with Nodejitsu ok
    info:    Executing command 
    info:    Welcome to Nodejitsu me
    info:    jitsu v0.12.3, node v0.10.0
    info:    It worked if it ends with Nodejitsu ok
    info:    Executing command 

    TypeError: Arguments to path.join must be strings
        at path.js:360:15
        at Array.filter (native)
        at Object.exports.join (path.js:358:36)
        at loadCommand (/usr/local/share/npm/lib/node_modules/jitsu/node_modules/flatiron/lib/flatiron/plugins/cli.js:211:45)
        at executeCommand (/usr/local/share/npm/lib/node_modules/jitsu/node_modules/flatiron/lib/flatiron/plugins/cli.js:278:26)
        at Object.app.router.notfound (/usr/local/share/npm/lib/node_modules/jitsu/node_modules/flatiron/lib/flatiron/plugins/cli.js:357:5)
        at Router.dispatch (/usr/local/share/npm/lib/node_modules/jitsu/node_modules/flatiron/node_modules/director/lib/director/cli.js:50:21)
        at execCommand (/usr/local/share/npm/lib/node_modules/jitsu/lib/jitsu.js:234:18)
        at jitsu.exec (/usr/local/share/npm/lib/node_modules/jitsu/lib/jitsu.js:247:54)
        at /usr/local/share/npm/lib/node_modules/jitsu/lib/jitsu.js:190:20
@blakmatrix

we should expose the rejectUnauthorized option to be passed along through config options should SSL ever fails for any reason. This would be a work around for remoteHost being set to api.jit.su in its current condition, also in the unlikely but possible case all three endpoints return SSL issues, thus allowing users to still use the tool.

@Southern

@julianduque submitted flatiron/flatiron#98 for the path.join error. There's also flatiron/flatiron#99 outlining some things wrong with the flatiron CLI plugin right now.

@julianduque

A lot of specific node 0.10.x errors were fixed in latest versions of jitsu, I will close this, if some error appears please feel free to reopen the issue.

@tommedema

The nodejitsu site still says that only node 0.6.x and 0.8.x are supported, so why is this issue closed?

@jcrugzz
Owner

@tommedema this issue had to do with our jitsu cli running with node 0.10.x. Keep an eye out this week for the 0.10.x support you are looking for :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.