Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Modified package.json not being validated properly #60

Closed
bmeck opened this Issue · 1 comment

1 participant

@bmeck

jitsu deploy is not validating "package.json" if it already existed and has been deployed. This means when the "package.json" updates the version number, it could write invalid deployment packages. For example:

info:   Analyzing your application dependencies in server.js
warn:   Your package.json version will be incremented for you automatically.
warn:   About to write /home/bradley/Documents/private/hellonode/package.json
data:   
data:   {
data:       name: 'hellonode',
data:       scripts: {},
data:       version: '0.0.0-1'
data:   }
data:   
prompt: Is this ok? (yes): ^C

Validation needs to be performed on all "package.json"s and the filling out of the package.json like other CLI work.

@bmeck

Fixed and pulled out the duplicated logic in package.create / get.

@bmeck bmeck closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.