Jitsu should have its own .ignore file #83

Closed
AvianFlu opened this Issue Aug 26, 2011 · 14 comments

Projects

None yet

10 participants

@AvianFlu
Contributor

Jitsu currently ignores files in a user's .gitignore and .npmignore files - this can be problematic. A configuration file full of database credentials and API keys doesn't belong on github, for example, but it definitely belongs in a deployment.

As a solution, Jitsu should perhaps have its own ignore file - .jitsuignore?

@dominictarr
Contributor

definately.
+1

@AvianFlu
Contributor

This is being checked in https://github.com/isaacs/npm/blob/master/lib/utils/tar.js#L431-443 - it would be a simple change in and of itself, except that we'd have to vendor most of npm to do it. Maybe this should be something that npm allows to be configurable?

@AvianFlu
Contributor

I just opened npm/npm#1329 in response to this issue - a fix on the npm side of things would make the fix on our end trivial.

@ghost
ghost commented May 1, 2012

Hi. Did anything happen with this? I've just discovered this is a problem.

@Siedrix
Siedrix commented May 4, 2012

+1 Same problem here.

@coderguy
coderguy commented May 6, 2012

+1 spent a lot of time debugging errors and finally realized my .gitignore files were causing some files to not be included.

Please update documentation to explain that files in the .gitignore will be excluded from the deploy. I only found it out digging through the issues.

It would be nice if you could set a preference for each project with the name of the .ignore file, something like in package.json
{
'ignore': ['.gitignore','.npmignore']
}

or
{
'ignore': '.jitsuignore'
}

@arxpoetica

+2

@pghalliday

+3 for me - just ran into this problem as i .gitignore my SSL certs and private keys but of course i want them to be deployed. I'm surprised this is low priority. I ran into this issue within minutes of starting to test nodejitsu for suitability for my project. I now have to get creative again ;)

@mmalecki
Contributor

Assigning this to myself, it needs few changes in fstream-npm which I'll pull request.

@mmalecki mmalecki was assigned Oct 20, 2012
@mmalecki mmalecki added a commit to mmalecki/fstream-npm that referenced this issue Oct 20, 2012
@mmalecki mmalecki Make ignore files configurable
This allows applications to use custom ignore files, example use case
being deployment.

Ref nodejitsu/jitsu#83.
baf12e7
@mmalecki mmalecki referenced this issue in npm/fstream-npm Oct 20, 2012
Closed

Make ignore files configurable #3

@mmalecki mmalecki added a commit that closed this issue Oct 20, 2012
@mmalecki mmalecki [api] Support `.jitsuignore` file
During packaging application, make `fstream-npm` read `.jitsuignore`
file to find files which should be ignored.

Depends on npm/fstream-npm#3.
Fixes #83.
e5f0636
@mmalecki mmalecki closed this in e5f0636 Oct 20, 2012
@mmalecki
Contributor

Reopening (pushed to a dev branch)

@mmalecki mmalecki reopened this Oct 20, 2012
@isaacs isaacs added a commit to npm/fstream-npm that referenced this issue Oct 22, 2012
@mmalecki @isaacs mmalecki + isaacs Make ignore files configurable
This allows applications to use custom ignore files, example use case
being deployment.

Ref nodejitsu/jitsu#83.
a958e43
@blakmatrix
Contributor

@mmalecki can you update this issue with a synopsis of where we are at in this issue, it seems to me, for now we are pretty satisfied with .npmignore now working. Are we still looking to have our own .jitsuignore file?

@indexzero
Member

@blakmatrix I think that's fixed in there, but I'm not sure if fstream-npm will use all ignore files or just the first one.

@isaacs
isaacs commented Feb 3, 2013

@indexzero You can put a .npmignore file anywhere, and it'll work, just the same as .gitignore files.

@mmalecki mmalecki added a commit that closed this issue May 28, 2013
@mmalecki mmalecki [api] Add `.jitsuignore` support
Fixes #83.
fef3929
@mmalecki mmalecki closed this in fef3929 May 28, 2013
@arxpoetica

Nice!

@mmalecki mmalecki was unassigned by omarmeky Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment