Conversation
It executes scripts from `package.json` `scripts` entry.
Contributor
|
Nice idea. Any security concerns though? |
Contributor
Author
|
What kind of security concerns are you talking about? Hooks are running on user's machine, it's nothing one couldn't do anyway. |
Contributor
|
None in particular was really just asking :) LGTM |
Contributor
Author
|
OK, thanks for review Nuno. @AvianFlu @jesusabdullah wanna take a look at it or should I merge? |
Contributor
|
I'll take a look, but a'priori this looks awesome. |
Contributor
Author
|
LGTM'd by @jesusabdullah and @pksunkara on IRC, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for hooks.
Currently supported hooks are
predeploy(executed before updating the tarball) andpostdeploy(executed after application is started).