Skip to content

Hooks #254

Merged
merged 4 commits into from Jun 20, 2012

3 participants

@mmalecki

Add support for hooks.

Currently supported hooks are predeploy (executed before updating the tarball) and postdeploy (executed after application is started).

@dscape
nodejitsu member
dscape commented Jun 20, 2012

Nice idea.

Any security concerns though?

@mmalecki

What kind of security concerns are you talking about? Hooks are running on user's machine, it's nothing one couldn't do anyway.

@dscape
nodejitsu member
dscape commented Jun 20, 2012

None in particular was really just asking :)

LGTM

@mmalecki

OK, thanks for review Nuno. @AvianFlu @jesusabdullah wanna take a look at it or should I merge?

@jfhbrook

I'll take a look, but a'priori this looks awesome.

@mmalecki

LGTM'd by @jesusabdullah and @pksunkara on IRC, merging.

@mmalecki mmalecki merged commit 8695d84 into master Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.