Hooks #254

Merged
merged 4 commits into from Jun 20, 2012

Conversation

Projects
None yet
3 participants
Contributor

mmalecki commented Jun 20, 2012

Add support for hooks.

Currently supported hooks are predeploy (executed before updating the tarball) and postdeploy (executed after application is started).

Member

dscape commented Jun 20, 2012

Nice idea.

Any security concerns though?

Contributor

mmalecki commented Jun 20, 2012

What kind of security concerns are you talking about? Hooks are running on user's machine, it's nothing one couldn't do anyway.

Member

dscape commented Jun 20, 2012

None in particular was really just asking :)

LGTM

Contributor

mmalecki commented Jun 20, 2012

OK, thanks for review Nuno. @AvianFlu @jesusabdullah wanna take a look at it or should I merge?

Contributor

jfhbrook commented Jun 20, 2012

I'll take a look, but a'priori this looks awesome.

Contributor

mmalecki commented Jun 20, 2012

LGTM'd by @jesusabdullah and @pksunkara on IRC, merging.

@mmalecki mmalecki added a commit that referenced this pull request Jun 20, 2012

@mmalecki mmalecki Merge pull request #254 from nodejitsu/hooks
Hooks
8695d84

@mmalecki mmalecki merged commit 8695d84 into master Jun 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment