Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes jitsu not reporting new version #391

Merged
merged 1 commit into from

3 participants

@dscape
Collaborator
  • Using the jitsu.log before init was making the code throw. Since it was in a try catch we never noticed. Until now...

Stare Dad

@dscape dscape [fix] Fixes jitsu not reporting new version
* Using the jitsu.log before init was making the code throw.
  Since it was in a try catch we never noticed.
  Until now...

![Stare Dad](http://cdn.superbwallpapers.com/wallpapers/meme/staredad-9237-400x250.jpg)
0ebdc1a
@dscape
Collaborator

Increase in timeout for folks like me in europe. Feel free to revert, but I couldn't get it with 400.

@indexzero
Owner

These look fine to me.

@blakmatrix blakmatrix merged commit aa6fc40 into from
@blakmatrix blakmatrix deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 15, 2013
  1. @dscape

    [fix] Fixes jitsu not reporting new version

    dscape authored
    * Using the jitsu.log before init was making the code throw.
      Since it was in a try catch we never noticed.
      Until now...
    
    ![Stare Dad](http://cdn.superbwallpapers.com/wallpapers/meme/staredad-9237-400x250.jpg)
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 8 deletions.
  1. +7 −7 lib/jitsu.js
  2. +1 −1  lib/jitsu/common/index.js
View
14 lib/jitsu.js
@@ -141,16 +141,16 @@ jitsu.start = function (callback) {
return;
}
- jitsu.common.checkVersion(function (err) {
+ jitsu.init(function (err) {
if (err) {
- return callback();
+ jitsu.welcome();
+ callback(err);
+ return jitsu.showError(jitsu.argv._.join(' '), err);
}
-
- jitsu.init(function (err) {
+
+ jitsu.common.checkVersion(function (err) {
if (err) {
- jitsu.welcome();
- callback(err);
- return jitsu.showError(jitsu.argv._.join(' '), err);
+ return callback();
}
//
View
2  lib/jitsu/common/index.js
@@ -173,7 +173,7 @@ common.checkVersion = function (callback) {
//
request({
uri: 'http://registry.npmjs.org/jitsu/latest',
- timeout: 400
+ timeout: 1000
}, function (err, res, body) {
if (!responded) {
responded = true;
Something went wrong with that request. Please try again.