[fix] process don't exit after jitsu deploy, drain event isn't called #408

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

julianduque commented Mar 13, 2013

Fixes #407

Contributor

blakmatrix commented Mar 13, 2013

LGTM. Though it is a bit worrysome we flip-flop so much on this 01e2ba1

Contributor

blakmatrix commented Mar 13, 2013

@mmalecki mentioned the change back had something to do with error reporting... so something to keep in mind when moving forward, since we have immediate plans to refactor the error managment in jitsu I feel this is very minor issue, and that we should procceed bundling this with the errs refactor.

Contributor

julianduque commented Mar 13, 2013

Not ready to be merged yet. I'm seeing issues on other jitsu commands, investigating.

Southern referenced this pull request in flatiron/flatiron Mar 16, 2013

Closed

Flatiron CLI plugin causing multiple problems. #99

3 of 3 tasks complete
Contributor

mmalecki commented Mar 17, 2013

This is a valid pull request. I'll merge this now.

Contributor

mmalecki commented Mar 17, 2013

Cherry-picked in e1d0f12.

mmalecki closed this Mar 17, 2013

julianduque deleted the gh-407 branch Mar 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment