Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[fix] process don't exit after jitsu deploy, drain event isn't called #408

Closed
wants to merge 1 commit into from

3 participants

@blakmatrix

LGTM. Though it is a bit worrysome we flip-flop so much on this 01e2ba1

@blakmatrix

@mmalecki mentioned the change back had something to do with error reporting... so something to keep in mind when moving forward, since we have immediate plans to refactor the error managment in jitsu I feel this is very minor issue, and that we should procceed bundling this with the errs refactor.

@julianduque

Not ready to be merged yet. I'm seeing issues on other jitsu commands, investigating.

@Southern Southern referenced this pull request in flatiron/flatiron
Closed

Flatiron CLI plugin causing multiple problems. #99

3 of 3 tasks complete
@mmalecki

This is a valid pull request. I'll merge this now.

@mmalecki

Cherry-picked in e1d0f12.

@mmalecki mmalecki closed this
@julianduque julianduque deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 4 deletions.
  1. +2 −4 bin/jitsu
View
6 bin/jitsu
@@ -9,7 +9,5 @@ jitsu.start(function (err) {
jitsu.log.info('Nodejitsu'.grey + ' ok'.green.bold);
}
- process.stdout.on('drain', function () {
- process.exit(err ? 1 : 0);
- });
-});
+ process.exit(err ? 1 : 0);
+});
Something went wrong with that request. Please try again.