We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/nodejitsu/kohai/blob/master/lib/plugins/alias.js#L30
This method needs to be refactored.
Insults should be stored as an array of strings in the config.json file. The code for sending insults should only be a few lines long.
The switch / case in this block of code has introduced an anti-pattern. You need to uncouple the data ( insults ) from the logic ( sending insults ).
The text was updated successfully, but these errors were encountered:
[refactor] Refactored !insult (#51)
dcfaadf
[refactor] Refactored !insult (#51), configuration now via private me…
de6e084
…ssage only to reduce channel noise
No branches or pull requests
https://github.com/nodejitsu/kohai/blob/master/lib/plugins/alias.js#L30
This method needs to be refactored.
Insults should be stored as an array of strings in the config.json file. The code for sending insults should only be a few lines long.
The switch / case in this block of code has introduced an anti-pattern. You need to uncouple the data ( insults ) from the logic ( sending insults ).
The text was updated successfully, but these errors were encountered: