Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Hi! I fixed some code for you! #42

Closed
wants to merge 2 commits into from

3 participants

@node-migrator-bot

Hi!

I am migrationBot!

Did you know that path.{exists,existsSync} was moved to fs.{exists,existsSync}, and that tty.setRawMode(mode) was moved to tty.ReadStream#setRawMode() (i.e. process.stdin.setRawMode()) in node v0.8.0? Read more @API changes between v0.6 and v0.8

I automatically made some changes I think will help you migrate your codebase to node v0.8.0, please review these changes and merge them if you feel they are useful, If they are not you can ignore this Pull Request.

Have a Nice Day!

--migrationBot

@jfhbrook

Interesting. Why are we vendoring mkdirp? Is that something we can avoid doing?

@jfhbrook

Just as a follow-up: @mmalecki said that we no longer need to vendor mkdirp. So, instead of doing this we should just de-vendor it.

@indexzero indexzero closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 vendor/mkdirp.js
View
4 vendor/mkdirp.js
@@ -6,7 +6,7 @@ exports.mkdirp = exports.mkdirP = function mkdirP (p, mode, f) {
if (p.charAt(0) != '/') { cb(new Error('Relative path: ' + p)); return }
var ps = path.normalize(p).split('/');
- path.exists(p, function (exists) {
+ fs.exists(p, function (exists) {
if (exists) cb(null);
else mkdirP(ps.slice(0,-1).join('/'), mode, function (err) {
if (err && err.code !== 'EEXIST') cb(err)
@@ -22,7 +22,7 @@ exports.mkdirpSync = exports.mkdirPSync = function mkdirPSync (p, mode) {
if (p.charAt(0) != '/') { throw new Error('Relative path: ' + p); return; }
var ps = path.normalize(p).split('/'),
- exists = path.existsSync(p);
+ exists = fs.existsSync(p);
function tryMkdirSync () {
try { fs.mkdirSync(p, mode); }
Something went wrong with that request. Please try again.