Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Host header and x-forwarded-for #23

Closed
c2c533c4f237 opened this Issue Jan 31, 2011 · 2 comments

Comments

Projects
None yet
2 participants

Forgive me if this post is slightly uninformed - I am new to Proxying in general. Today I tried to start a proxy to get around some cross domain issues I was having. Apparently the urls I need to proxy to depend on the Host header being the same as the actual domain. When I was hitting it with node-http-proxy, I got some 403s, since it was sending Host : localhost (or whatever). It turns out my service doesn't honor the x-forwarded-for header and I have to fake it, but I'm surprised that this library doesn't automatically append the x-forwarded-for header to the request. From my general understanding it seems like most proxy systems do inject this header, so why doesn't node-http-proxy?

Owner

indexzero commented Jan 31, 2011

That's a good question. Right now node-http-proxy isn't 100% compliant with rfc2616, but I'll leave this issue open as a reminder that we should be doing that.

There are going to be a lot of changes coming once 0.4.0 is stablized.

Owner

indexzero commented Apr 16, 2011

Fixed in a3cb527. Will be released in v0.5.0 in the next couple of days.

@indexzero indexzero closed this Apr 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment