Skip to content

closing server econnrefused #463

Closed
yawnt opened this Issue Sep 15, 2013 · 5 comments

3 participants

@yawnt
yawnt commented Sep 17, 2013

this should be fixed since error handling is now implemented.. @jcrugzz feel free to reopen if it's not the case

@yawnt yawnt closed this Sep 17, 2013
@jcrugzz jcrugzz reopened this Sep 19, 2013
@jcrugzz
nodejitsu member
jcrugzz commented Sep 19, 2013

The following example results in...

/n/j/proxy ❯❯❯ node primus-proxy.js
{ from: 'client', to: 'server' }
disconnected
{ from: 'server', to: 'client' }

/Users/jcrugzz/node.js/nodejitsu/node-http-proxy/lib/caronte/passes/web-incoming.js:108
        throw err;
              ^
Error: connect ECONNREFUSED
    at errnoException (net.js:901:11)
    at Object.afterConnect [as oncomplete] (net.js:892:19)

For one the error should be handled if the EventEmitter2 wildcards are working properly so I have not yet determined if the client will receive the end event (which it should) upon the server being destroyed due to the proxy crashing the process.

cc @yawnt

@jcrugzz jcrugzz referenced this issue Sep 19, 2013
Closed

error handling #462

@jcrugzz
nodejitsu member
jcrugzz commented Sep 19, 2013

@cronopio also we should have tests for cases like this for all the various transports as I believe we will hit some edge cases with various disconnects being triggered.

@cronopio

Ok, @jcrugzz by now there are tests for ws and socket.io and not for primus, I'll try to write it

@jcrugzz
nodejitsu member
jcrugzz commented Sep 20, 2013

@cronopio thanks! and make sure the test cases handle when the server closes and the proxy errors. Keep up the good work :)

@yawnt yawnt closed this Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.