Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the 2 minutes default incoming timeout by default, matches proxyTimeout defaut behavior #1273

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Johny101
Copy link

Johny101 commented Jun 12, 2018

Hi

This modification will save head hakes to those playing with long HTTP request.

Thanks!

Johny

DESCRIPTION:
Now, if the incoming timeout option is not set or if set to 0, it will be disabled by setting the req.socket timeout to 0.
This replace the default node.js 2 minutes timeout and now support disabling it.

It will have the same default behavior than the incoming proxyTimeout option.

TEST:
In a Windows and Arm-Linux environment, set option.timeout to 0, to 5 minutes and no timeout option.
Run a 8 minutes long request. Confirm expected behavior for all cases.

Jean Fontaine Jean Fontaine
Disable the 2 minutes default incoming timeout by default
DESCRIPTION:
If the incoming timeout option is not set or if set to 0, it will be disabled.
It will now have the same default behavior than the incoming proxyTimeout option.

This replace the default node.js 2 minutes timeout and now support disabling it.

TEST:
In a Windows and Arm-Linux environment, set option.timeout to 0, to 5 minutes and remove option.
Run a 8 minutes long request. Confirm expected behavior for all cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.