Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-standard URLs #1321

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@brandonros
Copy link

brandonros commented Jan 30, 2019

Our business has URLs like /node/sso/esi?&url=https%3A//redacted.banno.com/redacted/

This is obviously non-standard.

Running the URL through common.urlJoin messes it up unnecessarily.

This should be a safe change to avoid the "no-op" when outgoingPath is an empty string (making the call to common.urlJoin useless as far as I can tell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.