Update lib/node-http-proxy/http-proxy.js #311

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@valette

valette commented Sep 27, 2012

disable timeouts on connections, related to issue #278

Update lib/node-http-proxy/http-proxy.js
disable timeouts on connections
@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Nov 29, 2012

Owner

@valette This is correct, but it only fixes your issue. What about users who want a timeout? The solution is (of course) to make this configurable as an option passed around.

Please implement it as an option and add tests.

Owner

indexzero commented Nov 29, 2012

@valette This is correct, but it only fixes your issue. What about users who want a timeout? The solution is (of course) to make this configurable as an option passed around.

Please implement it as an option and add tests.

@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Mar 9, 2013

Owner

No traction on tests. Closing. Would accept this as a feature with:

  • configurable timeout
  • tests.
Owner

indexzero commented Mar 9, 2013

No traction on tests. Closing. Would accept this as a feature with:

  • configurable timeout
  • tests.

@indexzero indexzero closed this Mar 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment