Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Uncatchable error when upstream server returns malformed HTTP response #348

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

jcheng5 commented Dec 8, 2012

Without this commit, Node versions 0.9.1 and earlier cause the process to
terminate with no recourse if upstream HTTP servers return malformed HTTP
responses.

Fixes issue #347

@jcheng5 jcheng5 Forward errors that occur on response.connection
Without this commit, Node versions 0.9.1 and earlier cause the process to
terminate with no recourse if upstream HTTP servers return malformed HTTP
responses.

Fixes issue #347
4252933

jcheng5 commented Dec 8, 2012

I'm sorry but I just tested on Node 0.9.3 and it seems that WITH my patch the crash returns. Somehow my patch negates the fix in Node.

@jcheng5 jcheng5 closed this Dec 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment