Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

take into account user options when using a router #381

Closed
wants to merge 1 commit into from

2 participants

Sébastien Valette Charlie Robbins
Sébastien Valette

Thanks for the timeout options. Unfortunately, it does not work when using a router. This small modification does the trick. Is it correct?

related to #372

Charlie Robbins
Owner

The build failed on Travis. I will consider merging this when the tests pass.

Charlie Robbins
Owner

On second examination: this is the wrong approach. These are not the options you're looking for.

Charlie Robbins indexzero closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 11, 2013
  1. Sébastien Valette
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/node-http-proxy.js
2  lib/node-http-proxy.js
View
@@ -157,7 +157,7 @@ exports.createServer = function () {
// for them
//
handlers.push(function (req, res) {
- proxy.proxyRequest(req, res);
+ proxy.proxyRequest(req, res, options);
});
proxy.on('routes', function (routes) {
Something went wrong with that request. Please try again.