Skip to content

Mention Harmon used for response modifications in the readme #384

Merged
merged 2 commits into from Mar 16, 2013

4 participants

@No9
No9 commented Mar 16, 2013

As requested by @indexzero #382
Not sure exactly where I should put the text but middleware seemed to be the best section to me.

@indexzero indexzero merged commit 3ebc795 into nodejitsu:master Mar 16, 2013

1 check passed

Details default The Travis build passed
@gurjeet
gurjeet commented Mar 4, 2014

@indexzero @No9 This merge/code has been lost to later merges. This is a very useful information, and should be in the README!

Please re-pull this.

@jcrugzz
nodejitsu member
jcrugzz commented Mar 4, 2014

@gurjeet while this is an awesome plugin it is no longer compatible with the newest implementation as node-http-proxy has been simplified.

@gurjeet
gurjeet commented Mar 4, 2014

@jcrugzz Thanks for letting me know! I was planning on using it, but you saved me some head-banging :)

Are there any alternatives packages available?

@No9
No9 commented Mar 10, 2014

@gurjeet harmon is OPEN open source.
If you make an accepted pull request to upgrade to 1.0.0 http-proxy I will add you as an administrator

@No9
No9 commented Apr 16, 2014

@jcrugzz Thanks for your kind words!

So i have updated the harmon docs and tests to reflect the 1.x release version of http-proxy and we have upgraded trumpet. Can you let me know if you would accept a pull request on the README again or are you putting it somewhere else now?
cc @gurjeet @indexzero

@jcrugzz
nodejitsu member
jcrugzz commented Apr 17, 2014

@No9 I would totally accept a PR to put that in the docs :).

@No9 No9 referenced this pull request Oct 15, 2014
Merged

Adding harmon to the README #716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.