Looks like this may fix the issue that I reported #39

Merged
merged 1 commit into from Apr 26, 2011

Conversation

Projects
None yet
2 participants
Contributor

timmattison commented Apr 26, 2011

My installation doesn't like the parameters passed as "http, port" to getAgent. I think instanceof may want these variables to be instantiated with the String constructor according to some JavaScript documentation found online but I'm not sure.

In this patch all I did was create an options object and used it in both the HTTP and HTTPS constructors. After that the examples work again.

@indexzero indexzero added a commit that referenced this pull request Apr 26, 2011

@indexzero indexzero Merged pull request #39 from timmattison/master.
Looks like this may fix the issue that I reported
ac425d7

indexzero merged commit ac425d7 into nodejitsu:master Apr 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment