This adds a flag to ProxyRequest to disable the setting of x-forwarded-[for|port|proto] #73

Merged
merged 2 commits into from Jul 21, 2011

Projects

None yet

3 participants

@DanBUK
DanBUK commented Jul 19, 2011

When using multiple layers of proxies one needs the ability not to re-set x-forwarded-[for|port|proto] on every layer; as the first proxy sets these headers on further layers the headers should not be clobbered so the final destination sees the correct address.

@indexzero
Member

camelCase options are preferred over camel_case options (it's Javascript, not Ruby afterall). Can you please rename this to enableXForwarded and I will accept it.

@DanBUK
DanBUK commented Jul 19, 2011

Updated!

@indexzero
Member

This should be true by default:

options.enableXForwarded = options.enableXForwarded === true;
@dominictarr dominictarr merged commit 76aa982 into nodejitsu:master Jul 21, 2011
@dominictarr

defaults to true in e3d95ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment