Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditing for 6.11.1 #230

Closed
MylesBorins opened this issue Jun 13, 2017 · 17 comments

Comments

@MylesBorins
Copy link
Member

commented Jun 13, 2017

WORKING ON THIS NOW: nobody


My week is pretty hectic, does someone want to take point on starting to prep for 6.11.1?

Todo

  • Review PRs against v6.x
  • Review Backlog via branch diff
    branch-diff v6.x-staging upstream/v8.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts --filter-release
  • Go through baking-for-lts semver-patch commits (added by @gibfahn)
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 13, 2017

Dup of #228 ? Sorry, this is for going through the patches. I can do this.

Previous issue: #216

@gibfahn gibfahn self-assigned this Jun 13, 2017
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

Ran this with the --reverse flag. Got the following worrying messages (tried twice). Hopefully after we land a bunch of these the remaining ones won't trip whatever limit this is. Seems to be okay now that I've landed some backport PRs. Also excluded the land-on-v6.x label to exclude things like nodejs/node#10771.

Exact thing I ran:

branch-diff up/v6.x-staging up/v8.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts,land-on-v6.x --filter-release --reverse

  • [921d2b080e] - src: make cross-context MakeCallback() calls work ( Ben Noordhuis) #9221
  • [63c47e7189] - src: remove superfluous env_string string ( Ben Noordhuis) #9213
  • [4fb27d43f0] - intl: Add more versions from ICU ( Steven R. Loomis)
  • [099762de61] - dtrace: resolve conversion warnings from SLURP_INT ( Christopher J. Brody) #10143
  • [0c8cfd4eca] - eslint: remove dangling eslint symlink ( Sam Roberts) #10771
  • [822bbe0bb2] - test: fix linting for test-tls-add-ca-cert.js ( Sam Roberts) #10771
  • [5c2ef14f21] - http: optimize short path validation ( Brian White) #10654
  • [dab22b5b7a] - http: optimize default method case ( Brian White) #10654
  • [15c6187aa5] - http: avoid duplicate isArray() ( Brian White) #10654
  • [2f7759640e] - http: misc ClientRequest cleanup ( Brian White) #10654
  • [c5d0fd9641] - benchmark: add ClientRequest creation benchmark ( Brian White) #10654
  • [57e2ec4356] - test: add http.ClientRequest defaults test ( Brian White) #10654
  • [f3f2468bdc] - doc: fix CHANGELOG.md table formatting ( Сковорода Никита Андреевич) #10743
  • [030dd14793] - benchmark: add benchmark for vm.runIn*() ( Rich Trott) #10816
  • [ef1e77d186] - vm: improve performance of vm.runIn*() ( Rich Trott) #10816
  • [326e967c6b] - url: export URLSearchParams ( Timothy Gu)
  • [a024104eec] - test: improve test-fs-open-flags ( Vinícius do Carmo)
  • [147d2a6419] - url, test: break up test-url.js ( Joyee Cheung) #11049
  • [78545039d6] - test: remove unnecessary eslint-disable max-len ( Joyee Cheung) #11049
  • [10b687b58b] - test, url: synchronize WPT url tests ( Joyee Cheung) #11079
  • [907ce8dd6c] - test: refactor test-fs-error-messages.js ( Adrian Estrada) #11096
  • [046f66a554] - src: fix building --without-v8-plartform ( Myk Melez) #11088
  • [9562bf4bd4] - Revert "test: refactor test-fs-error-messages.js" ( James M Snell) #11155
  • [5e52a9ac09] - Revert "fs: allow WHATWG URL and file: URLs as paths" ( James M Snell) #11155
  • [901cb8cb5e] - test: increase coverage of buffer ( DavidCai) #11122
  • [ca8c30a35c] - doc: update output examples in debugger.md ( Vse Mozhet Byt) #10944
  • [f8cdaaa16a] - test: validate error message from buffer.equals ( Sebastian Roeder) #11215
  • [1544d8f04b] - test: improve test-buffer-includes.js ( toboid) #11203
  • [00c86cc8e9] - buffer: remove Uint8Array check ( Nikolai Vavilov) #11324
  • [82ddf96828] - test: turn on WPT tests on empty param pairs ( Joyee Cheung) #11369
  • [52b253677a] - doc: fix sorting in API references ( Vse Mozhet Byt) #11331
  • [dd2e135560] - test: add two test cases for querystring ( Daijiro Wachi) #11481
  • [3c92200d8b] - tty: add ref() so process.stdin.ref() etc. work ( Ben Schmidt) #7360
  • [dd81d539e2] - child_process: fix deoptimizing use of arguments ( Vse Mozhet Byt) #11535
  • [acc3a80546] - test: add two test cases for querystring ( Daijiro Wachi) #11551
  • [e1d8899c28] - src: add HAVE_OPENSSL directive to openssl_config ( Daniel Bevenius) #11618
  • [3b05153cdc] - doc: various improvements to net.md ( Joyee Cheung) #11636
  • [1402fef098] - test: make tests pass when configured without-ssl ( Daniel Bevenius) #11631
  • [60c8115f63] - test: clean up comments in test-url-format ( Rich Trott) #11679
  • [f6b0309861] - doc: argument types for https methods ( Amelia Clarke) #11681
  • [9772fb9282] - doc: http cleanup and missing argument types ( Amelia Clarke) #11681
  • [98e54b0bd4] - meta: restore original copyright header ( James M Snell) #10155
  • [df97727272] - doc: improve net.md on sockets and connections ( Joyee Cheung) #11700
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

For some reason the first one here (nodejs/node#6308) has the semver-major tag, which I've excluded. Not sure what I'm doing wrong.

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2017

it is possible to trip the abuse detection from all the traffic you send if there is a big delta

I worked a rate limited queue into branch-diff, you can maybe play with the options on that to avoid triggering the abuse bots... if you start getting requests rejected the filters don't end up working... which can explain why you are getting semver-major things leaking in

we could maybe permanently fix this by refactoring branch-diff to use graphql

@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

So all the ones I've done so far are ones that didn't land cleanly on v7.x, so someone commented saying "please backport", and then nothing happened. I'll put backport-requested-v6.x on them (as we have that tag now).

@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Splitting into multiple parts so the tickbox checking doesn't get too slow

Part 2:

  • [879d6663ea] - net: remove an unused internal module assertPort ( Daijiro Wachi) #11812
  • [73e2d0bce6] - doc: argument types for crypto methods ( Amelia Clarke) #11799
  • [474e9d64b5] - test: add more test cases of server.listen option ( Joyee Cheung)
  • [db39273a8a] - doc: increase Buffer.concat() documentation ( cjihrig) #11845
  • [379eec357d] - build: add cpp linting to windows build ( liusi) #11856
  • [ae8a8691e6] - benchmark: add final clean-up to module-loader.js ( Vse Mozhet Byt) #11924
  • [4eb194a2b1] - lib: Use regex to compare error message ( Kunal Pathak) #11854
  • [a8a042a6d3] - build: add lint option to vcbuild.bat help ( Morgan Brenner) #11992
  • [4929d12e99] - test: add internal/socket_list tests ( DavidCai) #11989
  • [e40ac30e05] - doc: document extent of crypto Uint8Array support ( Anna Henningsen) #11982
  • [4f2e372716] - test: add common.noop, default for common.mustCall() ( James M Snell) #12027
  • [20b18236de] - tools: add rule prefering common.mustNotCall() ( James M Snell) #12027
  • [d437841961] - doc: fix http properties documented as methods ( Ahmad Nassri) #12039
  • [d367a0a3ac] - doc: fix https.timeout docs ( Ahmad Nassri) #12039
  • [642baf4699] - benchmark: check end() argument to be > 0 ( Vse Mozhet Byt) #12030
  • [61ebfa8d1f] - tools: add unescaped regexp dot rule to linter ( Brian White) #11834
  • [b08490774d] - tools: add missing #include "unicode/putil.h" ( Steven R. Loomis) #12078
  • [92de91d570] - test: fix truncation of argv ( Daniel Bevenius) #12110
  • [53828e8bff] - test: extended test to makeCallback cb type check ( Luca Maraschi) #12140
  • [ba0e3ac53d] - doc: minor improvements in BUILDING.md ( Sakthipriyan Vairamani (thefourtheye)) #11963
  • [d19809a3c5] - build: avoid passing kill empty input in Makefile ( Gibson Fahnestock) #12158
  • [c79b081367] - doc: fix typo in CHANGELOG_V6.md ( Zero King) #12206
  • [74dc3bfe08] - benchmark: replace [].join() with ''.repeat() ( Vse Mozhet Byt) #12170
  • [5ccaba49f0] - test: add variable arguments support for Argv ( Daniel Bevenius) #12166
  • [08442621a2] - doc: fix fs.read arg type ( Daiki Arai) #12034
  • [e9f2ec4e1e] - doc: fix the timing of setImmediate's execution ( Daiki Arai) #12034
  • [eefdf452c3] - benchmark: avoid TurboFan deopt in arrays bench ( Michaël Zasso) #11894
  • [2ff107dad7] - test: add case for url.parse throwing a URIError ( Lovell Fuller) #12135
  • [610ac7d858] - test: increase coverage of internal/socket_list ( DavidCai) #12066
  • [491d59da84] - napi: supress invalid coverity leak message ( Michael Dawson) #12192
  • [65c100ae8b] - test: remove disabled debugger test ( Rich Trott) #12199
  • [c6e0ba31ec] - doc: update OS level support for AIX ( Michael Dawson) #12235
  • [b03f1f0c01] - test: add basic cctest for base64.h ( Alexey Orlenko) #12238
  • [afd5966fa9] - napi: initialize and check status properly ( Gabriel Schulhof) #12283
  • [8191af5b29] - tools: replace custom new-with-error rule ( Rich Trott) #12249
  • [65a6e05da5] - src: only block SIGUSR1 when HAVE_INSPECTOR ( Daniel Bevenius) #12266
  • [2555780aa6] - test: check curve algorithm is supported ( Karl Cheng) #12265
  • [cecdf7c118] - src: use a std::vector for preload_modules ( Sam Roberts) #12241
  • [c694633328] - build: sort phony rules ( Joyee Cheung) #12059
  • [baa2602539] - build: add test-gc-clean and test-gc PHONY rules ( Joyee Cheung) #12059
  • [569f988be7] - test: remove disabled tls_server.js ( Rich Trott) #12275
  • [9b6376a4ee] - doc: update os.uptime() and process.uptime() info ( Vse Mozhet Byt) #12294
  • [de168b4b4a] - src: guard bundled_ca/openssl_ca with HAVE_OPENSSL ( Daniel Bevenius) #12302
  • [b3f2e3b7e2] - tools: replace custom assert.fail lint rule ( Rich Trott) #12287
  • [0f69f40af0] - benchmark: replace more [].join() with ''.repeat() ( Vse Mozhet Byt) #12317
  • [9de2e159c4] - test: add second argument to assert.throws ( Michaël Zasso) #12270
  • [a4b9c585b3] - tools: enforce two arguments in assert.throws ( Michaël Zasso) #12270
  • [e505c079e0] - src: supply missing comments for CLI options ( Sam Roberts) #12245
  • [8086cb68ae] - src: use option parser for expose_internals ( Sam Roberts) #12245
  • [3900cf66a5] - test: remove disabled test-dgram-send-error ( Rich Trott) #12330
  • [3d2181c5f0] - test: run the addon tests last ( Sebastian Van Sande) #12062
  • [ea44b8b283] - build: disable -O3 for C++ coverage ( Anna Henningsen) #12406
  • [fbe946bb63] - benchmark,windows: TCP.readStart() meaningful only after completion ( Refael Ackermann) #12258
  • [f98db78f77] - test: add internal/fs tests ( DavidCai) #12306
  • [88aab45c92] - os,vm: fix segfaults and CHECK failure ( Tobias Nießen) #12371
  • [021719738e] - deps: update node-inspect to v1.11.2 ( Jan Krems) #12363
  • [e1d14873fe] - Revert "src: exclude node_root_certs when use-def-ca-store" ( Daniel Bevenius) #12391
  • [e72ea0da0b] - doc: modernize and fix code examples in process.md ( Vse Mozhet Byt) #12381
  • [b2803637e8] - src: replace IsConstructCall functions with lambda ( Daniel Bevenius) #12384
  • [4a782e12a8] - test: replace [].join() with ''.repeat() ( Jackson Tian) #12305
  • [fe1be39b28] - doc: child_process example for special chars ( Cody Deckard)
  • [7044065f1a] - test: change == to === in crypto test ( Fabio Campinho) #12405
  • [b837bd2792] - doc: fix typo in CHANGELOG.md ( Gautam krishna.R) #12434
  • [6c606916db] - Revert "test: port test for make_callback to n-api" ( James M Snell) #12475
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Part 3:

  • [2e5188de92] - test: remove common.PORT from multiple tests ( Tarun Batra) #12451
  • [7cd0d4f644] - buffer: fix backwards incompatibility ( Brian White) #12439
  • [3a334b1280] - tools: update gyp to eb296f6 ( Refael Ackermann) #12450
  • [e7c3f4a97b] - tools: fix gyp to work on MacOSX without XCode ( Shigeki Ohtsu) iojs/io.js#1325
  • [e6eac853a4] - tools: add compile_commands.json gyp generator ( Ben Noordhuis) #12450
  • [d727d5d2cf] - build: enable cctest to use objects (gyp part) ( Daniel Bevenius) #12450
  • [4fc11998b4] - test: add cwd ENOENT known issue test ( cjihrig) #12343
  • [6c912a8216] - test: fix coverity UNINIT_CTOR cctest warning ( Ben Noordhuis) #12387
  • [eaa0542eff] - crypto: remove unused C++ parameter in sign/verify ( Tobias Nießen) #12397
  • [b4f59a7460] - doc: upgrade Clang requirement to 3.4.2 ( Michaël Zasso) #12388
  • [5ef6000afd] - src: don't call uv_run() after 'exit' event ( Ben Noordhuis) #12344
  • [211813c99c] - doc: unify quotes in an assert.md code example ( Vse Mozhet Byt) #12505
  • [86a3ba0c4e] - test: dynamic port in cluster worker wait close ( Sebastian Plesciuc) #12466
  • [f97156623a] - module: standardize strip shebang behaviour ( Sebastian Van Sande) #12202
  • [f3f9dd73aa] - test: skip tests using ca flags ( Daniel Bevenius) #12485
  • [bb041ea5a0] - repl: support hidden history file on Windows ( Bartosz Sosnowski) #12207
  • [468275ac79] - n-api: remove napi_get_value_string_length() ( Jason Ginchereau) #12496
  • [58066d16d5] - events: remove unreachable code ( cjihrig) #12501
  • [5e095f699e] - test: verify listener leak is only emitted once ( cjihrig) #12502
  • [9077b48271] - lib: refactor internal/util ( James M Snell) #11404
  • [95ab006e8d] - doc: improve randomfill and fix broken link ( Sakthipriyan Vairamani (thefourtheye)) #12541
  • [75bfdad037] - test: check that pending warning is emitted once ( Rich Trott) #12527
  • [42dca99cd7] - doc, tools: add doc linting to CI ( Vse Mozhet Byt) #12640
  • [d1d9ecfe6e] - test: support unreleased V8 versions ( Michaël Zasso) #12619
  • [bda34bde56] - test: remove obsolete lint comment ( Rich Trott) #12659
  • [4241577112] - test: test doc'd napi_get_value_int32 behaviour ( Michael Dawson) #12633
  • [35d2137715] - doc: modernize and fix code examples in repl.md ( Vse Mozhet Byt) #12634
  • [1d968030d4] - test: add coverage for napi_cancel_async_work ( Michael Dawson) #12575
  • [e927809eec] - test: dynamic port in parallel regress tests ( Sebastian Plesciuc) #12639
  • [5bb06e8596] - src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h ( Daniel Bevenius) #12638
  • [28f535a923] - test: fixup test-http-hostname-typechecking ( Anna Henningsen) #12627
  • [d289678352] - test: dynamic port in dgram tests ( Sebastian Plesciuc) #12623
  • [892ce06dbd] - src: fix incorrect macro comment ( Daniel Bevenius) #12688
  • [427125491f] - n-api: Reference and external tests ( Jason Ginchereau) #12551
  • [a4fd9e5e6d] - test: chdir before running test-cli-node-options ( Daniel Bevenius) #12660
  • [71f22c842b] - doc: replace uses of you and other style nits ( James M Snell) #12673
  • [b16869c4e4] - test: remove AIX guard in fs-options-immutable ( Sakthipriyan Vairamani (thefourtheye)) #12687
  • [71911be1de] - doc: clarify arch support for power platforms ( Michael Dawson) #12679
  • [0101a8f1a6] - test: add relative path to accommodate limit ( coreybeaumont) #12601
  • [427cd293d5] - test: add hasCrypto check to test-cli-node-options ( Daniel Bevenius) #12692
  • [b07e1a828c] - v8: fix gcc 7 build errors ( Zuzana Svetlikova) #12676
  • [74f61e8e1f] - test: support multiple warnings in checkWarning ( Cameron Little) #11640
  • [a3132b0aa5] - process: cast promise rejection reason to string ( Cameron Little) #11640
  • [0324ac686c] - test: add inspect-brk option to cluster module ( dave-k) #12503
  • [0142276977] - test: replace indexOf with includes ( gwer) #12604
  • [6ed791c665] - deps: cherry-pick bfae9db from upstream v8 ( Ben Noordhuis) #12722
  • [579ff2a487] - process: refactor internal/process.js export style ( James M Snell) #12644
  • [ed0716f0e9] - module: refactor internal/module export style ( James M Snell) #12644
  • [e2199e0fc2] - streams: refactor BufferList into ES6 class ( James M Snell) #12644
  • [08809f28ad] - fs: simplify constant decls ( James M Snell) #12644
  • [ea9eed5643] - freelist: simplify export ( James M Snell) #12644
  • [a180259e42] - test,lib,doc: use function declarations ( Rich Trott) #12711
  • [aea7269c45] - tools: require function declarations ( Rich Trott) #12711
  • [595d4ec114] - tools: ignore node_trace.*.log ( Daijiro Wachi) #12754
  • [10ccf56f89] - test: skipIfInspectorDisabled cluster-inspect-brk ( Daniel Bevenius) #12757
  • [9f7b54945e] - Revert "test: remove eslint comments" ( Joyee Cheung) #12743
  • [9d723e85fb] - buffer: remove pointless C++ utility methods ( Anna Henningsen) #12760
  • [dc3bbb45a7] - cluster: remove debug arg handling ( Rich Trott) #12738
  • [c20e87a10e] - repl: fix /dev/null history file regression ( Brian White) #12762
  • [133fb0c3b7] - test: minor fixes to test-module-loading.js ( Walter Huang) #12728
  • [04796ee97f] - test: increase coverage of buffer ( David Cai) #12714
  • [cd32b77567] - n-api: remove unnecessary try-catch bracket from certain APIs ( Gabriel Schulhof) #12705
  • [d6a6bcdc47] - stream: remove unnecessary parameter ( Leo) #12767
  • [e488857402] - build: add static option to vcbuild.bat ( Tony Rice) #12764
  • [896be833c8] - node: add missing option to --help output ( Ruslan Bekenev) #12763
  • [2bf461e6f5] - doc: document vm timeout option perf impact ( Anna Henningsen) #12751
  • [55c95b1644] - http: fix first body chunk fast case for UTF-16 ( Anna Henningsen) #12747
  • [6993eb0897] - stream: fix y.pipe(x)+y.pipe(x)+y.unpipe(x) ( Anna Henningsen) #12746
  • [21653b6901] - src: add --napi-modules to whitelist ( Michael Dawson) #12733
  • [8aca66a1f3] - test: fix warning in n-api reference test ( Michael Dawson) #12730
  • [b2ab41e5ae] - test: increase readline coverage ( Anna Henningsen) #12761
  • [9990be2919] - src: turn buffer type-CHECK into exception ( Anna Henningsen) #12753
  • [6c2daf0ce9] - crypto: throw proper errors if out enc is UTF-16 ( Anna Henningsen) #12752
  • [d56a7e640f] - src: do proper StringBytes error handling ( Anna Henningsen) #12765
  • [ff001c12b0] - test: move WPT to its own testing module ( Rich Trott) #12736
  • [4677766d21] - test: enable test-debugger-pid ( Rich Trott) #12770
  • [ebcd8c6bb8] - src: rename CryptoPemCallback -> PasswordCallback ( Daniel Bevenius) #12787
  • [d0c968ea57] - src: make root_cert_vector function scoped ( Daniel Bevenius) #12788
  • [3f48ab3042] - inspector: do not add 'inspector' property ( Eugene Ostroukhov) #12656
  • [f971916885] - test: fix too optimistic guess in setproctitle ( Vse Mozhet Byt) #12792
  • [712596fc45] - test: add callback to fs.close() in test-fs-chmod ( Vse Mozhet Byt) #12795
  • [0258aed9d2] - doc: edit CONTRIBUTING.md for clarity etc. ( Rich Trott) #12796
  • [665695fbea] - test: add callback to fs.close() in test-fs-stat ( Vse Mozhet Byt) #12804
  • [53c88fa411] - tools: remove unused code from test.py ( Rich Trott) #12806
  • [bc05436a89] - test: add regex check in test-vm-is-context ( jeyanthinath) #12785
  • [1c93e8c94b] - win: make buildable on VS2017 ( Refael Ackermann) #11852
  • [f1d593cda1] - test: make tests cwd-independent ( Vse Mozhet Byt) #12812
  • [feb90d37ff] - tools: relax lint rule for regexps ( Rich Trott) #12807
  • [6bcf65d4a7] - lib,test: use regular expression literals ( Rich Trott) #12807
  • [8b76c3e60c] - test: reduce string concatenations ( Vse Mozhet Byt) #12735
  • [2614d247fb] - doc: update readFileSync in fs.md ( Aditya Anand) #12800
  • [15e160e626] - inspector: report when main context is destroyed ( Eugene Ostroukhov) #12814
  • [4703824276] - doc: fix commit guideline url ( Thomas Watson) #12862
  • [68c933c01e] - test: fix flakyness with yes.exe ( Refael Ackermann) #12821
  • [0f3e69db41] - v8: fix gcc 7 build errors ( Zuzana Svetlikova) #12676
  • [d74a545535] - deps: cherry-pick bfae9db from upstream v8 ( Ben Noordhuis) #12722
  • [3fd890a06e] - test: add mustCall in timers-unrefed-in-callback ( Zahidul Islam) #12594
  • [7e5f500c98] - assert: improve deepEqual perf for large input ( Anna Henningsen) #12849
  • [a710e443a2] - test: complete coverage of buffer ( David Cai) #12831
  • [a398516b4f] - doc: remove test-npm from general build doc ( Rich Trott) #12840
  • [9318f82937] - readline: use module.exports = {} ( James M Snell) #12755
  • [392a8987c6] - readline: use module.exports = {} on internal/readline ( James M Snell) #12755
  • [4ac7a68ccd] - readline: multiple code cleanups ( James M Snell) #12755
  • [4c070d4897] - readline: move escape codes into internal/readline ( James M Snell) #12755
  • [d37f27a008] - test: expand test coverage of readline ( James M Snell) #12755
  • [dac9f42a7e] - test: remove common.PORT in test tls ticket cluster ( Oscar Martinez) #12715
  • [6058c4349f] - test: refactored test-repl-persistent-history ( cool88) #12703
  • [152966dbb5] - test: refactoring test with common.mustCall ( weewey) #12702
  • [cbd6fde9a3] - doc: improve path.posix.normalize docs ( Steven Lehn) #12700
  • [42958d1a75] - test: refactor test-querystring ( Łukasz Szewczak) #12661
  • [0a734fec88] - test: fix napi test_reference for recent V8 ( Michaël Zasso) #12864
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Part 4:

  • [ea1b8a5cbc] - doc: sort bottom-of-file markdown links ( Sam Roberts) #12726
  • [f6247a945c] - assert: restore TypeError if no arguments ( Rich Trott) #12843
  • [dc4313c620] - test: remove unused testpy code ( Rich Trott) #12844
  • [65d6249979] - benchmark: update an obsolete path ( Vse Mozhet Byt) #12904
  • [212a7a609d] - net: ensure net.connect calls Socket connect ( Thomas Watson) #12861
  • [dd0624676c] - meta: fix nits in README.md collaborators list ( Vse Mozhet Byt) #12866
  • [771568a5a5] - test: add test for timers benchmarks ( Joyee Cheung) #12851
  • [f72376d323] - test: add skipIfInspectorDisabled to debugger-pid ( Daniel Bevenius) #12882
  • [e429f9a42a] - doc: fix typo in streams.md ( Glenn Schlereth) #12924
  • [824fb49a70] - lib: remove useless default caught ( Jackson Tian) #12884
  • [94eed0fb11] - test: use dynamic port instead of common.PORT ( Aditya Anand) #12473
  • [147048a0d3] - doc: fix broken links in n-api doc ( Michael Dawson) #12889
  • [5d0a770c12] - deps: ICU 59.1 bump ( Steven R. Loomis) #12486
  • [57a08e2f70] - test: remove obsolete lint config comments ( Rich Trott) #12868
  • [e1cabf6fbd] - doc, test: add note to response.getHeaders ( Refael Ackermann) #12887
  • [317180ffe5] - test: fix flaky test-https-client-get-url ( Sebastian Plesciuc) #12876
  • [cfe7b34058] - test: use assert regexp in tls no cert test ( Artur Vieira) #12891
  • [13487c437c] - doc: add docs for server.address() for pipe case ( Flarna) #12907
  • [dd6e3f69a7] - src: fix comments re PER_ISOLATE macros ( Josh Gavant) #12899
  • [6914aeaefd] - test: detect all types of aborts in windows ( Gireesh Punathil) #12856
  • [54d331895c] - lib: add guard to originalConsole ( Daniel Bevenius) #12881
  • [bee250c232] - test: dynamic port in cluster disconnect ( Sebastian Plesciuc) #12545
  • [bb88caec06] - build: fix ninja build failure ( Daniel Bevenius) #12484
  • [9fd22bc4d4] - build: fix ninja build failure (GYP patch) ( Daniel Bevenius) #12484
  • [631cb42b4e] - test: favor deepStrictEqual over deepEqual ( Rich Trott) #12883
  • [abfd4bf9df] - doc: clarify node.js addons are c++ ( Beth Griggs) #12898
  • [9ce2271e81] - https: support agent construction without new ( cjihrig) #12927
  • [b6001a2da5] - src: make SIGPROF message a real warning ( cjihrig) #12709
  • [c79deaab82] - doc: update to add ref to supported platforms ( Michael Dawson) #12931
  • [6f449db60f] - fs: refactor deprecated functions for readability ( Rich Trott) #12910
  • [a82e0e6f36] - benchmark: check for time precision in common.js ( Rich Trott) #12934
  • [d7d16f7b8b] - doc: Change options at STEP 5 in CONTRIBUTING.md ( kysnm) #12830
  • [9f8e030f1b] - src: add/move hasCrypto checks for async tests ( Daniel Bevenius) #12968
  • [15410797f2] - src: add HAVE_OPENSSL guard to crypto providers ( Daniel Bevenius) #12967
  • [529e4f206a] - test: make a test path-independent ( Vse Mozhet Byt) #12945
  • [56812c81a3] - test: use dynamic port in test-https-connect-address-family ( Artur G Vieira) #12915
  • [1d5f5aa7e1] - doc: update COLLABORATOR_GUIDE.md ( morrme) #12555
  • [642bd4dd6d] - test: add a simple abort check in windows ( Sreepurna Jasti) #12914
  • [7c3a23b9c1] - inspector: handle socket close before close frame ( Eugene Ostroukhov) #12937
  • [98609fc1c4] - timers: do not use user object call/apply ( Rich Trott) #12960
  • [3fa5d80eda] - benchmark: chunky http client should exit with 0 ( Joyee Cheung) #12916
  • [84fc069b95] - test: move test-dgram-bind-shared-ports to sequential ( Rafael Fragoso) #12452
  • [945f208081] - test: make the rest of tests path-independent ( Vse Mozhet Byt) #12972
  • [b5ae22dd1c] - test: add hasCrypto check to https-agent-constructor ( Daniel Bevenius) #12987
  • [b7bc09fd60] - test: add not-called check to heap-profiler test ( Rich Trott) #12985
  • [72e3dda93c] - test: use mustCall in tls-connect-given-socket ( vperezma) #12592
  • [60f0dc7d42] - src: rename CONNECTION provider to SSLCONNECTION ( Daniel Bevenius) #12989
  • [32f01c8c11] - src: remove unused uv.h include in async-wrap.h ( Daniel Bevenius) #12973
  • [88d2e699d8] - test: remove unneeded string splitting ( Vse Mozhet Byt) #12992
  • [f4390650e3] - deps: cherry-pick 4ae5993 from upstream OpenSSL ( Shigeki Ohtsu) #12913
  • [e896898dea] - deps: update openssl asm and asm_obsolete files ( Shigeki Ohtsu) #12913
  • [ef16319eff] - util: fixup internal util exports ( James M Snell) #12998
  • [b23d414c7e] - tls: do not wrap net.Socket with StreamWrap ( Ruslan Bekenev) #12799
  • [276720921b] - addons: remove semicolons from after module definition ( Gabriel Schulhof) #12919
  • [1b28022de0] - doc: clarify operation of napi_cancel_async_work ( Michael Dawson) #12974
  • [0c2edd27e6] - test: fixed flaky test-net-connect-local-error ( Sebastian Plesciuc) #12964
  • [986e1d2c6f] - deps: cherry-pick f5fad6d from upstream v8 ( daniel.bevenius) #12826
  • [fefab9026b] - src: only call FatalException if not verbose ( Daniel Bevenius) #12826
  • [92f3b301ab] - doc: document method for reverting commits ( Gibson Fahnestock) #13015
  • [7906ed50fa] - test: add regex check in test-url-parse-invalid-input ( Andrei Cioromila) #12879
  • [4aff0563aa] - build: reduce one level of spawning in node_gyp ( Refael Ackermann) #12653
  • [80355271c3] - build: simplify if in setting of arg_paths ( Refael Ackermann) #12653
  • [f2ba06db92] - benchmark: remove redundant timers benchmark ( Rich Trott) #13009
  • [ad7b98baa8] - build: don't print directory for GNUMake ( Daniel Bevenius) #13042
  • [5debcceafc] - test: add hasCrypto to tls-wrap-event-emmiter ( Daniel Bevenius) #13041
  • [6342988053] - build: clean up napi build in test-addons-clean ( Joyee Cheung) #13034
  • [d6cd466a25] - src: whitelist new options for NODE_OPTIONS ( Sam Roberts) #13002
  • [6933419cb9] - test: add hasCrypto to tls-lookup ( Daniel Bevenius) #13047
  • [5de722ab6d] - doc: fix links from ToC to subsection for 4.8.x ( Frank Lanitz) #13039
  • [47e3d00241] - test: refactor test-dns-regress-6244.js ( Rich Trott) #13058
  • [5a948f6f64] - dns: fix crash using dns.setServers after resolve4 ( XadillaX) #13050
  • [28ddac2ec2] - buffer: fix indexOf for empty searches ( Anna Henningsen) #13024
  • [7e5ed8bad9] - test: track callback invocations ( Rich Trott) #13010
  • [29d89c9855] - src: split CryptoPemCallback into two functions ( Daniel Bevenius) #12827
  • [a593c74f81] - test: refactor test-vm-new-script-new-context ( Akshay Iyer) #13035
  • [ab34f9dec2] - doc: update doc to remove usage of "you" ( Michael Dawson) #13067
  • [eff9252181] - doc: update doc of publicEncrypt method ( Faiz Halde) #12947
  • [847688018c] - doc: don't suggest setEncoding for binary streams ( Rick Bullotta) #11363
  • [6b1819cff5] - test: use dynamic port in test-cluster-dgram-reuse ( Artur Vieira) #12901
  • [51664fc265] - net: add symbol to normalized connect() args ( cjihrig) #13069
  • [6f216710eb] - test: ignore spurious 'EMFILE' ( Refael Ackermann) #12698
  • [46e773c5db] - src: check if --icu-data-dir= points to valid dir ( Ben Noordhuis)
  • [fccc0bf6e6] - test: add mustCallAtLeast ( Refael Ackermann) #12935
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Part 5:

  • [3702ae732e] - doc: add additional useful ci job to list ( Michael Dawson) #13086
  • [4a7b7e8097] - doc: add reference to node_api.h in docs ( Michael Dawson) #13084
  • [6bfdeedce5] - async_wrap: add asyncReset to TLSWrap ( Refael Ackermann) #13092
  • [658741b9d9] - test: refactor test-https-set-timeout-server ( Rich Trott) #13032
  • [525497596a] - test: refactor test-net-GH-5504 ( Rich Trott) #13025
  • [c60a7fa738] - test: move net reconnect error test to sequential ( Artur G Vieira) #13033
  • [8250bfd1e5] - fs: Revert throw on invalid callbacks ( Myles Borins) #12976
  • [bfade5aacd] - doc: remove unused/duplicated reference links ( Daijiro Wachi) #13066
  • [595e5e3b23] - test: port disabled readline test ( Rich Trott) #13091
  • [2b541471db] - dns: fix resolve failed starts without network ( XadillaX) #13076
  • [ef71824740] - doc: edit Error.captureStackTrace html comment ( Artur Vieira) #12962
  • [6fb27af70a] - async_hooks: add constructor check to async-hooks ( Shadowbeetle) #13096
  • [72429b3981] - benchmark: allow no duration in benchmark tests ( Rich Trott) #13110
  • [1af8b70c57] - test: allow for absent nobody user in setuid test ( Rich Trott) #13112
  • [94eca79d5d] - src: remove unused node_buffer.h include ( Daniel Bevenius) #13095
  • [57b9b9d7d6] - src: remove unnecessary return statement ( Daniel Bevenius) #13094
  • [60132e83c3] - src: check IsConstructCall in TLSWrap constructor ( Daniel Bevenius) #13097
  • [f81281737c] - src: remove unnecessary forward declaration ( Daniel Bevenius) #13081
  • [96925e1b93] - test: replace common.PORT in dgram test ( Artur Vieira) #12929
  • [8ef4fe0af2] - test: use dynamic port in test-dgram-send-callback-buffer ( Artur Vieira) #12942
  • [9fc47de8e6] - test: use dynamic port in test-dgram-send-address-types ( Artur Vieira) #13007
  • [8a4f3b7dfc] - test: bind to 0 in dgram-send-callback-buffer-length ( Artur Vieira) #12943
  • [511ee24310] - test: remove common.PORT from dgram test ( Artur Vieira) #12944
  • [1acd4d2cc4] - src: assert that uv_async_init() succeeds ( cjihrig) #13116
  • [e6c03c78f7] - test: fix sequential test-net-connect-local-error ( Sebastian Plesciuc) #13064
  • [1aa68f9a8d] - doc: list macOS as supporting filename argument ( Chris Young) #13111
  • [1263b70e9e] - src: remove unused parameters ( Brian White) #13085
  • [85e2d56df1] - src: fix typo ( Brian White) #13085
  • [69f3db4571] - http,https: avoid instanceof for WHATWG URL ( Brian White) #12983
  • [414f93ecb3] - http: fix IPv6 Host header check ( Brian White) #13122
  • [268a39ac2a] - test: add hasCrypto check to async-wrap-GH13045 ( Daniel Bevenius) #13141
  • [50af2b95e0] - errors: AssertionError moved to internal/error ( Faiz Halde) #12906
  • [4fabcfc5a2] - Revert "net: remove unnecessary process.nextTick()" ( Evan Lucas) #12854
  • [6cfb876d54] - test: add regression test for immediate socket errors ( Evan Lucas) #12854
  • [f06f8365e4] - crypto: remove unnecessary template class ( Daniel Bevenius) #12993
  • [77dfa2b1da] - build: avoid /docs/api and /docs/doc/api upload ( Rod Vagg) #12957
  • [8914f7b4b7] - stream: improve readable push performance ( Brian White) #13113
  • [9f01b34bf9] - doc: link to common docs in test writing guide ( Anna Henningsen) #13118
  • [4cbdac3183] - src: redirect-warnings to file, not path ( Sam Roberts) #13120
  • [191bb5a358] - vm: fix displayErrors in runIn.. functions ( Marcel Laverdet) #13074
  • [6b25c75cda] - vm: fix race condition with timeout param ( Marcel Laverdet) #13074
  • [1da674e2c0] - test: check number of message events ( Rich Trott) #13125
  • [110a3b2657] - test: confirm callback is invoked in fs test ( Rich Trott) #13132
  • [1d587ef982] - doc: fix incorrect keyboard shortcut ( Alexey Orlenko) #13134
  • [3c91145f31] - doc: improve formatting of STYLE_GUIDE.md ( Alexey Orlenko) #13135
  • [2c45e6fd68] - doc: update code example for Windows in stream.md ( Vse Mozhet Byt) #13138
  • [db90b505e8] - doc: don't use useless constructors in stream.md ( Vse Mozhet Byt) #13145
  • [cd70a520d2] - test: check noop function invocations ( Rich Trott) #13146
  • [9100cac146] - test: simplify assert usage in test-stream2-basic ( Rich Trott) #13146
  • [e012f5a412] - test: move stream2 test from pummel to parallel ( Rich Trott) #13146
  • [d4e9e0f7e4] - doc: add jasongin & kunalspathak to collaborators ( Jason Ginchereau) #13200
  • [39785c7780] - inspector: document bad usage for --inspect-port ( Sam Roberts) #12581
  • [7fe5303983] - test: fix disabled test-fs-largefile ( Rich Trott) #13147
  • [a985ed66c4] - test: refactor test-dns ( Rich Trott) #13163
  • [c15fe8b78e] - stream: remove dup property ( Calvin Metcalf) #13216
  • [b781fa7b06] - test: add override to ServerDone function ( Daniel Bevenius) #13166
  • [5ad4170cd9] - test: cover util.format() format placeholders ( cjihrig) #13159
  • [2648c8de30] - deps: backport 6d38f89d from upstream V8 ( Ali Ijaz Sheikh) #13162
  • [287b11dc8c] - src: allow --tls-cipher-list in NODE_OPTIONS ( Sam Roberts) #13172
  • [e554bb449e] - async_hooks: only set up hooks if used ( Anna Henningsen) #13177
  • [4fa2ee16bb] - src: add linux getauxval(AT_SECURE) in SafeGetenv ( Daniel Bevenius) #12548
  • [597aff0846] - test: cover dgram handle send failures ( cjihrig) #13158
  • [b4f6ea06eb] - src: make StreamBase::GetAsyncWrap pure virtual ( Anna Henningsen) #13174
  • [c4502728fb] - test: refactor event-emitter-check-listener-leaks ( Rich Trott) #13164
  • [72a319e417] - test: refactor event-emitter-remove-all-listeners ( Rich Trott) #13165
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Part 6:

  • [f077e51c92] - src,fs: calculate fs times without truncation ( Daniel Pihlstrom) #12607
  • [d99b7bc8c9] - fs: fix realpath{Sync} on resolving pipes/sockets ( Ebrahim Byagowi) #13028
  • [cd2824cc93] - doc: make the style of notes consistent ( Alexey Orlenko) #13133
  • [4030aed8ce] - test: skip test-bindings if inspector is disabled ( Daniel Bevenius) #13186
  • [7b97f07340] - crypto: remove root_cert_store from node_crypto.h ( Daniel Bevenius) #13194
  • [686e753b7e] - test: use common.mustNotCall in test-crypto-random ( Rich Trott) #13183
  • [3becb0206c] - lib,src: improve writev() performance for Buffers ( Brian White) #13187
  • [c0a7c8e0d2] - doc: fix code example in inspector.md ( Vse Mozhet Byt) #13182
  • [b8b6c2c262] - stream: emit finish when using writev and cork ( Matteo Collina) #13195
  • [145ab052df] - src: add comment for TicketKeyCallback ( Anna Henningsen) #13193
  • [bb77cce7a1] - inspector: add missing virtual destructor ( Eugene Ostroukhov) #13198
  • [d0dbd53eb0] - test: add coverage for socket write after close ( cjihrig) #13171
  • [776028c46b] - querystring: improve unescapeBuffer() performance ( Jesus Seijas) #12525
  • [81b9b857aa] - doc,build: update configure help messages ( Gibson Fahnestock) #12978
  • [e7d098cea6] - src: ignore unused warning for inspector-agent.cc ( Daniel Bevenius) #13188
  • [2c5c2bda61] - test: check noop invocation with mustNotCall() ( Rich Trott) #13205
  • [9d922c6c0e] - src: fix InspectorStarted macro guard ( Daniel Bevenius) #13167
  • [735902f326] - build: support dtrace on ARM ( Bradley T. Hughes) #12193
  • [4f4d5d24f4] - build: ignore more VC++ artifacts ( Refael Ackermann) #13208
  • [8d193919fb] - test: replace indexOf with includes ( Aditya Anand) #13215
  • [fb6cf2f861] - build: xz tarball extreme compression ( Peter Dave Hello) #10626
  • [0be029ec97] - doc: make spelling of behavior consistent ( Michael Dawson) #13245
  • [ec7cbaf266] - src: update NODE_MODULE_VERSION to 57 ( Michaël Zasso) #12995
  • [0f3bfaf530] - v8: backport bd59e7452be from upstream v8 ( Michael Achenbach) #13217
  • [188630b84c] - v8: backport a9e56f4f36d from upstream v8 ( Peter Marshall) #13217
  • [13a961e9dc] - v8: backport 4f82f1d948c from upstream v8 ( hpayer) #13217
  • [a56f9698cb] - v8: backport 4f82f1d948c from upstream v8 ( hpayer) #13217
  • [1061e43739] - v8: backport faf5f52627c from upstream v8 ( Peter Marshall) #13217
  • [cfdcd6cf33] - v8: backport 43791ce02c8 from upstream v8 ( kozyatinskiy) #13217
  • [c8be718749] - v8: backport pieces from 18a26cfe174 from upstream v8 ( Peter Marshall) #13217
  • [686dd36930] - doc: fix api docs style ( Daijiro Wachi) #13236
  • [ea6941f703] - test: refactor test-fs-assert-encoding-error ( Rich Trott) #13226
  • [945916195c] - crypto: return CHECK_OK in VerifyCallback ( Daniel Bevenius) #13241
  • [010f864426] - inspector: --debug* deprecation and invalidation ( Refael Ackermann) #12949
  • [40572c5def] - doc: remove Gitter badge from README ( Rich Trott) #13231
  • [dd14ab608e] - doc: create list of CTC emeriti ( Rich Trott) #13232
  • [ac2e8820c4] - src: reduce duplicate code in SafeGetenv() ( cjihrig) #13220
  • [6083c4dc10] - deps: upgrade npm to 5.0.0 ( Kat Marchán) #13276
  • [d985ca7d4a] - deps: float patch on npm to fix citgm ( Myles Borins) #13305
  • [f0ad3bb695] - test: hasCrypto https-server-keep-alive-timeout ( Daniel Bevenius) #13253
  • [a2d49545a7] - test: support candidate V8 versions ( Michaël Zasso) #13282
  • [bee1421501] - doc: fix doc styles ( Daijiro Wachi) #13270
  • [7cc6fd8403] - test: improve n-api coverage for typed arrays ( Michael Dawson) #13244
  • [ec357bf88f] - test: use mustNotCall() in test-stream2-objects ( Rich Trott) #13249
  • [25a05e5db1] - test: fix flaky test-fs-watchfile on macOS ( Rich Trott) #13252
  • [243643e5e4] - doc: fix typo in n-api.md ( JongChan Choi) #13323
  • [9df8e2a3e9] - test: use mustCall() in test-readline-interface ( Rich Trott) #13259
  • [c2d7b41ac7] - doc: fix code examples in url.md ( Vse Mozhet Byt) #13288
  • [830049f784] - test: refactor test-net-server-bind ( Rich Trott) #13273
  • [561c14ba12] - doc: modernize and fix code examples in util.md ( Vse Mozhet Byt) #13298
  • [b8b0bfb1a7] - doc: add tniessen to collaborators ( Tobias Nießen) #13371
  • [a95f080160] - n-api: enable napi_wrap() to work with any object ( Jason Ginchereau) #13250
  • [41f0af524d] - doc: async-hooks documentation ( Thorsten Lorenz) #13287
  • [e4f37568e2] - doc: fix date for 8.0.0 changelog ( Myles Borins) #13360
  • [b16dd98387] - test: consolidate n-api test addons ( Michael Dawson) #13317
  • [eb6e9a0c9a] - doc: remove 'you' from writing-tests.md ( Michael Dawson) #13319
  • [16605cc3e4] - doc: add async_hooks, n-api to _toc.md and all.md ( Vse Mozhet Byt) #13379
  • [2a29c07d9e] - test: mark inspector-port-zero-cluster as flaky ( Refael Ackermann)
  • [1729574cd7] - doc: fix link in CHANGELOG_V8 ( James, please) #13313
  • [e20f3577d0] - test: improve test-https-server-keep-alive-timeout ( Rich Trott) #13312
  • [bccda4f2b8] - tools: be explicit about including key-id ( Myles Borins) #13309
  • [81ddeb98f6] - readline: clean up event listener in onNewListener ( Gibson Fahnestock) #13266
  • [8620aad573] - src: added newline in help message ( Josh Ferge) #13315
  • [b3c9bff254] - http: describe parse err in debug output ( Sam Roberts) #13206
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Part 7

  • [dccd1d2d31] - test: improve dns internet test case ( Brian White) #13261
  • [007a033820] - dns: improve callback performance ( Brian White) #13261
  • [92de432780] - dns: use faster IP address type check on results ( Brian White) #13261
  • [d1b39d92d6] - test: add known_test request with Unicode in the URL ( David D Lowe) #13297
  • [47c9de9842] - assert: fix deepEqual RangeError: Maximum call stack size exceeded ( rmdm) #13318
  • [93e91a4f3f] - test: check inspector support in test/inspector ( Daniel Bevenius) #13324
  • [dcadeb4fef] - build: fix typo ( Nikolai Vavilov) #13396
  • [3c55d1aea4] - doc: refine spaces in example from vm.md ( Vse Mozhet Byt) #13334
  • [a872399ddb] - doc: update who to cc for n-api ( Michael Dawson) #13335
  • [291669e7d8] - build: streamline JS test suites in Makefile ( Rich Trott) #13340
  • [1b192f936a] - doc: fix code examples in zlib.md ( Vse Mozhet Byt) #13342
  • [406c2cd8e4] - test: make test-fs-watchfile reliable ( Rich Trott) #13385
  • [6917df2a80] - async_wrap: run destroy in uv_timer_t ( Trevor Norris) #13369
  • [c208f9d51f] - test: check destroy hooks are called before exit ( Anna Henningsen) #13369
  • [4e687605ee] - doc: use destructuring in code examples ( Vse Mozhet Byt) #13349
  • [6cd5312b22] - doc: unify spaces in object literals ( Vse Mozhet Byt) #13354
  • [2d25e09b0f] - doc: add object-curly-spacing to doc/.eslintrc ( Vse Mozhet Byt) #13354
  • [11e428dd99] - doc: add require modules in url.md ( Daijiro Wachi) #13365
  • [29f19b6d39] - test: add documentation for common.mustNotCall() ( Rich Trott) #13359
  • [52c0c47856] - doc: suggest xcode-select --install ( Gibson Fahnestock) #13264
  • [818c935add] - test: test async-hook triggerId properties ( Dávid Szakállas) #13328
  • [837ecc01eb] - doc: update who to cc for async_hooks ( Anna Henningsen) #13332
  • [9db02dcc85] - async_hooks,http: fix socket reuse with Agent ( Anna Henningsen) #13348
  • [641979b213] - doc: resume a stream after pipe() and unpipe() ( Matteo Collina) #13329
  • [44c8ea32df] - doc,stream: clarify 'data', pipe() and 'readable' ( Matteo Collina) #13432
  • [159294d7d5] - doc: use prefer-rest-params eslint rule in docs ( Vse Mozhet Byt) #13389
  • [414da1b7a1] - doc: fix nits in code examples of async_hooks.md ( Vse Mozhet Byt) #13400
  • [376ac5fc3e] - inspector: Allows reentry when paused ( Eugene Ostroukhov) #13350
  • [339d220eed] - test: rearrange inspector headers into convention ( Sam Roberts) #13428
  • [48cad9cde6] - tools: fix node args passing in test runner ( Brian White) #13384
  • [a666238ffe] - events: fix potential permanent deopt ( Brian White) #13384
  • [103de0e69a] - process: fix permanent deopt ( Brian White) #13384
  • [41eaa4b6a6] - net: fix permanent deopt ( Brian White) #13384
  • [afe91ec957] - http: assert parser.consume argument's type ( Gireesh Punathil) #12288
  • [2e3b758006] - test,module: make message check MUI dependent ( Refael Ackermann) #13393
  • [b8e90ddf53] - assert: fix deepEqual similar sets and maps bug ( Joseph Gentle) #13426
  • [fb73070068] - test: consolidate n-api test addons - part2 ( Michael Dawson) #13380
  • [7be1a1cd47] - test: fix build warning in addons-napi/test_object ( Jason Ginchereau) #13412
  • [e991cd79f3] - doc: add ref to option to enable n-api ( Michael Dawson) #13406
  • [640101b780] - src: remove process._inspectorEnbale ( cjihrig) #13460
  • [01278bdd64] - tools: fix order of ESLint rules ( Michaël Zasso) #13363
  • [f47ce01dfb] - win, doc: document per-drive current working dir ( Bartosz Sosnowski) #13330
  • [791b5b5cbe] - src: remove ' print modifier ( Refael Ackermann) #13447
  • [8f2b82a2b4] - errors,tty: migrate to use internal/errors.js ( Gautam Mittal) #13240
  • [e6e42c1f75] - doc: fix typo "ndapi" in n-api.md ( Jamen Marz) #13484
  • [ffa7debd7a] - deps: upgrade npm to 5.0.3 ( Kat Marchán) #13487
  • [b3fb909d06] - lib: "iff" changed to "if and only if" ( Jacob Jones) #13496
  • [68e06e6945] - test: increase coverage of async_hooks ( David Cai) #13336
  • [a117bcc0a7] - doc: Add URL argument with http/https request ( Vladimir Trifonov) #13405
  • [ba817d3312] - url: update IDNA handling ( Timothy Gu) #13362
  • [5644dd76a5] - fs: replace a bind() with a top-level function ( Matteo Collina) #13474
  • [658560ee5b] - test,fs: test fs.watch for filename ( Refael Ackermann) #13411
  • [757ae521b5] - test: validate full error messages ( aniketshukla) #13453
  • [26e5b6411f] - doc: update linux supported versions ( cjihrig) #13306
  • [0caa09da60] - gitignore: add libuv book and GitHub template ( cjihrig) #13306
  • [65f22e481b] - build: use existing variable to reduce complexity ( Bryce Baril) #2883
  • [71a3d2c87e] - test: refactor test-dgram-oob-buffer ( Rich Trott) #13443
  • [968596ec77] - deps: upgrade libuv to 1.12.0 ( cjihrig) #13306
  • [2778256680] - doc: remove note highlighting in GOVERNANCE doc ( Rich Trott) #13420
  • [a9be8fff58] - doc: minimal documentation for Emeritus status ( Rich Trott) #13421
  • [3d12e1b455] - doc: emphasize Collaborators in GOVERNANCE.md ( Rich Trott) #13423
  • [216cb3f6e9] - test,benchmark: stabilize child-process ( Refael Ackermann) #13457
  • [fe5ea3feb0] - test: check callback not invoked on lookup error ( Rich Trott) #13456
  • [ad07c46b00] - test: refactor domain tests ( Rich Trott) #13480
  • [dd158b096f] - src: make IsConstructCall checks consistent ( Daniel Bevenius) #13473
  • [8c5407d321] - doc: corrects reference to tlsClientError ( Tarun) #13533
  • [85cac4ed53] - doc: update new CTC members ( Refael Ackermann) #13534
  • [bf61d97742] - async_hooks: make sure .{en|dis}able() === this ( Anna Henningsen) #13418
  • [c8db0475e0] - test: refactor test-fs-read-* ( Rich Trott) #13501
  • [61c73085ba] - async_hooks: minor refactor to callback invocation ( Anna Henningsen) #13419
  • [f134c9d147] - src: correct indentation for X509ToObject ( Daniel Bevenius) #13543
  • [d1fa59fbb7] - child_process: simplify send() result handling ( Brian White) #13459
  • [0ca4bd1e18] - child_process: reduce nextTick() usage ( Brian White) #13459
  • [6a696d15ff] - inspector: fix crash on exception ( Nikolai Vavilov) #13455
  • [98d7f25181] - doc: fix out of date sections in n-api doc ( Michael Dawson) #13508
  • [1c7f9171c0] - test: add coverage for napi_property_descriptor ( Michael Dawson) #13510
  • [4a96ed4896] - src: check whether inspector is doing io ( Sam Roberts) #13504
  • [bdbeb33dcb] - test: add hijackStdout and hijackStderr ( XadillaX) #13439
  • [1f88cbd620] - test: refactor test-http-server-keep-alive-timeout ( realwakka) #13448
  • [12036a1d73] - test: exercise once() with varying arguments ( cjihrig) #13524
  • [bf065344cf] - stream: ensure that instanceof fast-path is hit. ( Benedikt Meurer) #13403
  • [d66d4fc94c] - child_process: promisify includes stdio in error ( Gil Tayar) #13388
  • [f686f73465] - test: add coverage for AsyncResource constructor ( Gergely Nemeth) #13327
  • [3da56ac9fb] - test: harden test-dgram-bind-shared-ports ( Refael Ackermann) #13100
  • [4d27930faf] - test: fix flaky test-tls-socket-close ( Rich Trott) #13529
  • [c4cbd99d37] - https: support rejectUnauthorized for unix sockets ( cjihrig) #13505
  • [d51b1c2e6f] - cluster, dns, repl, tls, util: fix RegExp nits ( Vse Mozhet Byt) #13536
  • [53ec50d971] - doc: fix napi_create_*_error signatures in n-api ( Jamen Marzonie) #13544
  • [0df6c0b5f0] - Revert "readline: clean up event listener in onNewListener" ( Anna Henningsen) #13560
  • [2ea529b797] - test: add regression test for 13557 ( Anna Henningsen) #13560
  • [a5f415fe83] - src: merge fn_name in NODE_SET_PROTOTYPE_METHOD ( XadillaX) #13547
  • [2c1133d5fe] - doc: add readline.emitKeypressEvents note ( Samuel Reed) #9447
  • [b967b4cbc5] - build: merge test suite groups ( Refael Ackermann) #13378
  • [52f5e3f804] - doc: use HTTPS URL for suggested upstream remote ( Nikolai Vavilov) #13602
  • [00d2f7c818] - build,windows: check for VS version and arch ( Refael Ackermann) #13485
  • [812e0b0fbf] - test: refactor async-hooks test-callback-error ( Rich Trott) #13554
  • [4c5457fae5] - test: fix flaky test-http-client-get-url ( Sebastian Plesciuc) #13516
  • [26d76307d5] - doc: fs constants for Node < v6.3.0 in fs.md ( Anshul Guleria) #12690
  • [70432f2111] - doc: fix incorrect fs.utimes() link ( Justin Beckwith) #13608
  • [32c87ac6f3] - benchmark: fix some RegExp nits ( Vse Mozhet Byt) #13551
  • [e713482147] - test: fix typo in test-cli-node-options.js ( Vse Mozhet Byt) #13558
  • [68c0518e48] - doc: fix links and typos in fs.md ( Vse Mozhet Byt) #13573
  • [38a1cfb5e6] - v8: add a js class for Serializer/Dserializer ( Rajaram Gaunker) #13541
  • [fff8a56d6f] - http: handle cases where socket.server is null ( Luigi Pinca) #13578
  • [50e1f931a9] - profiler: declare missing printErr ( Fedor Indutny) #13590
  • [a0f8faa3a4] - v8: fix debug builds on Windows ( Bartosz Sosnowski) #13634
@refack

This comment has been minimized.

Copy link
Member

commented Jun 30, 2017

Been watching you're WG meeting... How can I help?

@AndreasMadsen

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

I don't think the async_hooks and async_wrap changes should be included in node.js v6. Considering a number of issues (nodejs/node#13352) we have had with HTTP I'm not comfortable including it in an LTS release. We are also considering a number of API changes which also not ideal for an LTS release.

@AndreasMadsen

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

@MylesBorins I can see that you are posting a lot of messages in async_hooks PRs. Please see my comment above.

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@AndreasMadsen sorry I missed this... was just going through the generic audit. I'll mark them all as don't land from now on

@AndreasMadsen

This comment has been minimized.

Copy link
Member

commented Jul 18, 2017

@MylesBorins I've now added dont-land labels to all async_hooks PRs, except the main async_hooks PR (nodejs/node#12892) where I set it to lts-watch. Sorry about the confusion.

@gibfahn

This comment has been minimized.

Copy link
Member

commented Aug 10, 2017

This is now done.

@gibfahn gibfahn closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.