Navigation Menu

Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

update benchmark dependency #274

Merged
merged 1 commit into from Jun 4, 2019
Merged

update benchmark dependency #274

merged 1 commit into from Jun 4, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented May 23, 2019

The package.json file hasn't been updated in 3 years. npm install && npm audit reveals some outdated dependencies of benchmark@2.0.0. Update
the package.json and add a package-lock.json.

The package.json file hasn't been updated in 3 years. `npm install &&
npm audit` reveals some outdated dependencies of benchmark@2.0.0. Update
the package.json and and add a package-lock.json.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented May 30, 2019

Anything holding this one up from being merged?

@mhdawson
Copy link
Member

mhdawson commented Jun 4, 2019

Landing and then will start a test run to see if things still run ok.

@mhdawson mhdawson merged commit ba5ecc5 into nodejs:master Jun 4, 2019
@mhdawson
Copy link
Member

mhdawson commented Jun 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants